Posts: 15,263
Joined: Jan 2009
Reputation:
727
ronie
Team-Kodi Member
Posts: 15,263
<onclick>ShowSubtitles</onclick> works ok for me in confluence / xbmc nightly build.
Posts: 1,012
Joined: Jan 2007
Reputation:
32
I'm on OpenELEC-ION.x86_64-3.2.3 (12.2 Git:97A9F05). Must be just this build then, thanks for confirming. I guess I'll have to wait for 3.2.4 or something.
Not the end of the world, XBMC is still the greatest media player in the world, subtitle button or no subtitle button.
Using a NUC7PJYHN and a 2820FYKH0 Intel NUC running LibreELEC, and two FireTVs.:)
Posts: 1,012
Joined: Jan 2007
Reputation:
32
Ok, so I thought it was just my OpenElec build so I figured I'd wait until an update, but I tried my Stable windows build from the main download site, and the last two nightlies, none turn off the subtitles when I execute a <onclick>ShowSubtitles</onclick>.
In addition, the the XBMCSetup-20131109-21c1810-master doesn't even play mp4 based embedded subtitles (external srts still work)
What am I doing wrong?
Using a NUC7PJYHN and a 2820FYKH0 Intel NUC running LibreELEC, and two FireTVs.:)
Posts: 1,155
Joined: Aug 2008
Not sure if these two are connected, but i tried to use the new subtitle popup thing from Gotham with 12.2, but the actions would not do anything.
Only action that did something was <onclick>XBMC.RunScript($INFO[Skin.String(SubtitleScript_Path)])</onclick>
All the remaining 3 were translated from button presses to XBMC actions based on the debug log, but nothing happened.
<onclick>SubtitleDelay</onclick>
<onclick>NextSubtitle</onclick>
<onclick>ShowSubtitles</onclick>
Since it seeming sends regular onclicks it doesn't need a specific XBMC build, or does it?
I'm talking about
https://github.com/xbmc/xbmc/blob/master...deoOSD.xml and lines 533-594.
Posts: 118
Joined: Mar 2012
Reputation:
1
echo
Senior Member
Posts: 118
Found this thread by searching for "<onclick>ShowSubtitles</onclick>"
I am making my own mini VideoOSD and placed a button for enabling/disabling subtitles with the mentioned onclick.
I can confirm that it doesn't work for me as well ... running 12.2 Frodo.
The command does work when mapped to a key, but doesn't in the skin with the onclick.
Posts: 26,215
Joined: Oct 2003
Reputation:
187
It possibly depends where you're calling it from if this is Frodo - i.e. it may be window-specific.
In Gotham, it's handled by the player controller so is no longer window-specific.
Posts: 118
Joined: Mar 2012
Reputation:
1
echo
Senior Member
Posts: 118
Thanks jmarshall, hopefully it's sorted out in Gotham, so won't worry about it now.
Posts: 1,012
Joined: Jan 2007
Reputation:
32
Cool, cool, cool.
For reference it was being called from VideoOSD.xml.
Using a NUC7PJYHN and a 2820FYKH0 Intel NUC running LibreELEC, and two FireTVs.:)
Posts: 1,012
Joined: Jan 2007
Reputation:
32
Just tried it on xbmc-13.0-Gotham_alpha9.exe, same thing, it does nothing to the state of subtitles, if they're on, the stay on, if they're off, they stay off.
Using a NUC7PJYHN and a 2820FYKH0 Intel NUC running LibreELEC, and two FireTVs.:)
Posts: 1,012
Joined: Jan 2007
Reputation:
32
It's still broken in Jan 24, 2014 Windows nightly.
Using a NUC7PJYHN and a 2820FYKH0 Intel NUC running LibreELEC, and two FireTVs.:)
Posts: 26,215
Joined: Oct 2003
Reputation:
187
Yeah - this is because these actions are only handled in fullscreen (I thought they were handled in the playercontroller, but they're not).
It may or may not be an easy fix - will have to be explored.
Posts: 26,215
Joined: Oct 2003
Reputation:
187
Yup, as the second <onclick> is done in the context of fullscreen.