2014-10-20, 13:50
Hi Unfledged,
First of all, I really like your work with this addon.
I've spent the last few weeks on adopting your addon in my skin, it works beautifully for both home menu's, submenu's, widgets, backgrounds.
I do have one question however...
I noticed that the default for the script is to share the homemenu items across different skins.
Is it also possible to make this user-selectable ?
OR: skin selectable, so the skinner can provide it's default shortcuts ?
For example I support multiple libraries in my skins so I provide a good set of default shortcuts, submenu's and widgets with my skin.
As I released the beta yesterday from my skin with the skinshortcuts-integration I noticed that users don't get my defaults unless they reset to shortcut defaults in settings (if they used the script before for antother skin).
Basically I want to ask them if they like to receive the skin default shortcuts or just use the existing menu and if yes do the reset, is that even possible ?
If not I will just use the normal command for reset and the user gets 2 confirmation prompts..
Besides my question I have one small problem...
I have a few shortcut items that have visibility conditions based on a Home-window property...
Also the title gets read from a window property.
I suspect that the skinshortcuts-script doesn't actually parse those window-properties as it outputs $INFO[propertydescription...] as labels for those items instead of the actual title.
Also I'm not sure if the visibility conditions will be checked correctly with those window-properties. This behaviour is only in the settings dialog. In the actual home menu the shortcuts offcourse displays and works fine.
I also tried to use skin strings for this but noticed that also doesn't work :-)
Do you see any possibility to add a check in the code to replace the window-property with the actual value in the settings dialog ?
For now I temporary "fixed a hack" for it in DialogSelect to show "custom title" as the listitem's title instead of the nasty $INFO[blabla] string...
I provide a list with custom library entries (for mediabrowser addon) from where they can choose from but now they have to trial and error to get the right entry :-)
Offcourse I'd be happy to make the modification myself and provide you the merge request.
Really great addon! Thanks for your time/help in advance!
Regards,
Marcel
EDIT: now that I'm reading all the forumthread I see you just created an option to hide the warning... Will go that way than...
<onclick>RunScript(script.skinshortcuts,type=resetall,warning=false)</onclick>
Only the issue with the window properties remains...
First of all, I really like your work with this addon.
I've spent the last few weeks on adopting your addon in my skin, it works beautifully for both home menu's, submenu's, widgets, backgrounds.
I do have one question however...
I noticed that the default for the script is to share the homemenu items across different skins.
Is it also possible to make this user-selectable ?
OR: skin selectable, so the skinner can provide it's default shortcuts ?
For example I support multiple libraries in my skins so I provide a good set of default shortcuts, submenu's and widgets with my skin.
As I released the beta yesterday from my skin with the skinshortcuts-integration I noticed that users don't get my defaults unless they reset to shortcut defaults in settings (if they used the script before for antother skin).
Basically I want to ask them if they like to receive the skin default shortcuts or just use the existing menu and if yes do the reset, is that even possible ?
If not I will just use the normal command for reset and the user gets 2 confirmation prompts..
Besides my question I have one small problem...
I have a few shortcut items that have visibility conditions based on a Home-window property...
Also the title gets read from a window property.
I suspect that the skinshortcuts-script doesn't actually parse those window-properties as it outputs $INFO[propertydescription...] as labels for those items instead of the actual title.
Also I'm not sure if the visibility conditions will be checked correctly with those window-properties. This behaviour is only in the settings dialog. In the actual home menu the shortcuts offcourse displays and works fine.
I also tried to use skin strings for this but noticed that also doesn't work :-)
Do you see any possibility to add a check in the code to replace the window-property with the actual value in the settings dialog ?
For now I temporary "fixed a hack" for it in DialogSelect to show "custom title" as the listitem's title instead of the nasty $INFO[blabla] string...
I provide a list with custom library entries (for mediabrowser addon) from where they can choose from but now they have to trial and error to get the right entry :-)
Offcourse I'd be happy to make the modification myself and provide you the merge request.
Really great addon! Thanks for your time/help in advance!
Regards,
Marcel
EDIT: now that I'm reading all the forumthread I see you just created an option to hide the warning... Will go that way than...
<onclick>RunScript(script.skinshortcuts,type=resetall,warning=false)</onclick>
Only the issue with the window properties remains...