2019-12-22, 01:26
(2019-12-19, 00:28)AnonTester Wrote: Thanks. I have never done a PR and trying to read up on it just left me confused. Need to do some more reading over the Christmas break as I've got various other addons on my local system which I've been trying to make py3 compatible. In particular Skin Helper Service Widgets, thetvdb api2, skin helper service, and watchdog. I will need to read up on py2/3 compatibility though as I just fixed error messages I saw in the logs for py3, so those changes wouldn't be good enough for PRs.
There's a weird issue with banner images and thumbnails of the recently added episodes and next episode widgets. Those widgets don't properly get the show thumbnail to hide spoilers and the banners are somewhat random. Not sure whether this is a problem with the current kodi19 nightlies, my skin (Estuary Modv2) or an issue in one of the addons not working quite right yet...
Either way, I'll upload the changes to my github page and post links to the various forum entries in the hopes that it'll be helpful and we'll end up with compatible addons eventually.
Sorry, I obviously wasn't clear - I've made the pull request (PR - the technical term for asking for code changes to existing code on Github) myself, so no need to worry about you doing it (though, if you find issues and can PR the fixes yourself, well, that's fantastic!) The relevant PR is here - https://github.com/mikesilvo164/script.s...ts/pull/11
The script isn't responsible for how skins actually display widgets, so any issue with banner or thumbnail issues is something you'd need to take up with the relevant skinner,