2014-01-30, 11:17
@delinend/@popcornmix:
After plumbing my Pi into my Onkyo 828 amp (what a palava!) I've spent the last couple of hours testing old and new builds with respect to this refresh issue.
I deleted guisettings.xml and set "Adjust display refresh rate to match video" set to "Always", and apart from enabling debug logging, changed nothing else. My advancedsettings.xml does not include any defaultdvdplayer settings, so omxplayer is the default player and that is what I used for all tests.
Going as far back as mid December, all of my Gotham builds have this same 25Hz in, 25Hz out behaviour (or 29.970/30Hz in, 30Hz out). 24Hz in is output at 24Hz. So this is not a recent problem.
I then created a build without any newclock3 patches (but still using the latest Jan 28 firmware), and now 25Hz material is being output at 50Hz (and 30Hz material at 60Hz), so it's definitely a newclock3 patch that is causing this difference in video refresh rate behaviour.
I proceeded to build Gotham with just the following newlock3 patch, and the 25Hz in, 25Hz out and 30Hz in, 30Hz out behaviour returned:
so that would appear to be the culprit.
Personally I'm not even sure this new behaviour should be classed as "wrong", it seems more logical to me but if it causes juddering on some setups (and doubling the frame rate doesn't) then I guess using the higher frame rate is the way to go...
Here's a debug log, without the 3D switching patch, when playing 24Hz, 25Hz and 29.970Hz material (output at 24Hz, 50Hz and 60Hz respectively).
Here's a debug log, WITH the 3D switching patch, playing the same 24Hz, 25Hz and 29.970Hz material (output at 24Hz, 25Hz and 30Hz respectively).
If you look at where each build detects 3D movies, the difference is clear:
Without 3D switching patch - playing 29.970 material (output at 60Hz):
and now with the 3D switching patch, same 29.970 material this time output at 30Hz:
After plumbing my Pi into my Onkyo 828 amp (what a palava!) I've spent the last couple of hours testing old and new builds with respect to this refresh issue.
I deleted guisettings.xml and set "Adjust display refresh rate to match video" set to "Always", and apart from enabling debug logging, changed nothing else. My advancedsettings.xml does not include any defaultdvdplayer settings, so omxplayer is the default player and that is what I used for all tests.
Going as far back as mid December, all of my Gotham builds have this same 25Hz in, 25Hz out behaviour (or 29.970/30Hz in, 30Hz out). 24Hz in is output at 24Hz. So this is not a recent problem.
I then created a build without any newclock3 patches (but still using the latest Jan 28 firmware), and now 25Hz material is being output at 50Hz (and 30Hz material at 60Hz), so it's definitely a newclock3 patch that is causing this difference in video refresh rate behaviour.
I proceeded to build Gotham with just the following newlock3 patch, and the 25Hz in, 25Hz out and 30Hz in, 30Hz out behaviour returned:
Code:
popcornmix/xbmc/commit/a674b64876f81813036485de22fe15de95d5ed58 [3D] Support switching to 3D resolutionsso that would appear to be the culprit.
Personally I'm not even sure this new behaviour should be classed as "wrong", it seems more logical to me but if it causes juddering on some setups (and doubling the frame rate doesn't) then I guess using the higher frame rate is the way to go...
Here's a debug log, without the 3D switching patch, when playing 24Hz, 25Hz and 29.970Hz material (output at 24Hz, 50Hz and 60Hz respectively).
Here's a debug log, WITH the 3D switching patch, playing the same 24Hz, 25Hz and 29.970Hz material (output at 24Hz, 25Hz and 30Hz respectively).
If you look at where each build detects 3D movies, the difference is clear:
Without 3D switching patch - playing 29.970 material (output at 60Hz):
Code:
09:05:50 T:2928178256 NOTICE: not a 3D movie
09:05:50 T:2928178256 DEBUG: ResolutionUpdateCallBack - change configuration. video:1920x1080. framerate: 29.97. 720x480 format: BYPASS
09:05:50 T:2928178256 NOTICE: Display resolution ADJUST : 1920x1080 (1920x1080) @ 60.00 - Full Screen (19) (weight: 0.001)and now with the 3D switching patch, same 29.970 material this time output at 30Hz:
Code:
09:10:22 T:2716857424 NOTICE: not a 3D movie
09:10:22 T:2716857424 DEBUG: ResolutionUpdateCallBack - change configuration. video:1920x1080. framerate: 29.97. 720x480 format: BYPASS
09:10:22 T:2716857424 NOTICE: Display resolution ADJUST : 1920x1080 (1920x1080) @ 30.00 - Full Screen (25) (weight: 0.002)