2014-06-02, 23:29
If they're XBMC PRs, and seem fairly sane, and stand a good chance of being accepted eventually (ie. nothing too contentious) then yeah, I can include them, although I need to be careful as every extra PR has the potential to break the build if/when the PR rots and/or introduces changes that conflict with newclock3. This particular PR looks like it might cause a few problems but I'll try and include it in the next build and see what shakes out.
So it looks like PR4817 has been binned in preference to PR4837.
Edit: Having read all the comments on PR4837 it might be best to wait a few more days before including it. A ton of comments on a PR is not usually a good sign, best to wait until comments die down after reaching some sort of consensus...
PR4839 looks interesting.
(2014-06-02, 23:22)popcornmix Wrote: There were a couple more PR's from the same author that I've now added to newclock3 which could help other use cases
(it will use a cheaper file existence check which could help video startup time when playing from a crowded directory).
So it looks like PR4817 has been binned in preference to PR4837.
Edit: Having read all the comments on PR4837 it might be best to wait a few more days before including it. A ton of comments on a PR is not usually a good sign, best to wait until comments die down after reaching some sort of consensus...
PR4839 looks interesting.
