Posts: 201
Joined: May 2010
Reputation:
4
2014-10-18, 16:13
(This post was last modified: 2014-10-18, 16:21 by toolpunk.)
I would love to see all spin controls replaced by selection dialogs or dropdowns as they leave you clueless about what options you have. So you end up cycling through a potentially long list hoping to find a setting you like. They basically prevent you from making a quick decision.
Spinners are useful for numeric inputs, but if I'm not mistaken XBMC / Kodi uses sliders for those, which makes me believe changing the spin control's behavior shouldn't break existing functionality.
Posts: 7,135
Joined: Oct 2012
un1versal
Out of Memory (1939–2016)
Posts: 7,135
2014-10-18, 16:17
(This post was last modified: 2014-10-18, 16:20 by un1versal.)
You mean [Feature Request] Replace All Spin Controls
Speaking of removal the duplicate entries from such lists like resolution one has double 1920x1080 you have no idea if that is for progressive or interlaced anyway if its not duplicates then duplicate entries should be distinguished from the others.
Posts: 10,572
Joined: Oct 2011
Reputation:
644
jjd-uk
Team-Kodi Member
Posts: 10,572
I think this was under consideration. When audio settings were redone between Frodo & Gotham exactly this point was made, hence why Audio Device selection is a list now and not a spinner as previously.
I think at the moment changes are only being made as setting areas are updated or revisited, so to speed it up it needs someone to through all the dialogs and make the change everywhere, however I've not seen anything to suggest anyone on the Team has the time or motivation to do this at the moment, so it would probably have to come from the community.
Posts: 7,135
Joined: Oct 2012
un1versal
Out of Memory (1939–2016)
Posts: 7,135
If I had the the necessary skills it would be already done.
Posts: 201
Joined: May 2010
Reputation:
4
My C++ skills are a little rusty, but I think I should be able to do this. It's perhaps a little time consuming but it should be a rather easy copy & paste job.
Posts: 31,445
Joined: Jan 2011
I hate the way about 80% (probably more) of the spin controls in XBMC/Kodi are used. A list or dropdown menu would be much better in those cases.
Posts: 5,184
Joined: Jan 2009
Reputation:
131
The problem right now with replacing spinners with the selection dialog is that the selection dialog does not scale to the number of options so if you have a setting with 3 options and you use the selection dialog you get a huge dialog with 3 small options at the top and the rest of the dialog is a huge waste of empty space.
Anything that is part of the settings window in XBMC (i.e. what you see under System --> Settings but not e.g. the video or audio playback settings when playing a video) can easily be adjusted in settings.xml by changing the control type from "spinner" to "list" so it doesn't even need C++ skills. But I'm against such a change for settings with a very limited number of options due to the above reason. It works perfectly fine for things like language etc where there are a ton of options though.
Always read the
online manual (wiki),
FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the
forum rules (wiki).
Please read the pages on
troubleshooting (wiki) and
bug reporting (wiki) before reporting issues.
Posts: 201
Joined: May 2010
Reputation:
4
Could you elaborate on why you think it's a waste of space for short lists?
You've located a setting of interest and might want to change it. You however have no clue what the options are and start cycling through them. Let's call them A,B,C and D. After finding out about all of them, that is when you return to A, you decide that C is pretty much the best of the bunch and need two additional clicks to get back there. So short lists which fit on a single page would actually benefit the most from this change.
While you're dealing with the configuration of a specific setting the other settings aren't of much interest, so they don't need to be visible. If anything they might distract you from the task at hand, which is why I don't think it's waste of space at all.
Posts: 7,135
Joined: Oct 2012
un1versal
Out of Memory (1939–2016)
Posts: 7,135
I think he means the size of the selection dialog/list is the same size weather there's 200 options or 2 in which the one with 2 option you see 90% empty space.
while making all lists show a dialog for selection instead of a spinner is pure xml change, making that dialog dynamic size is not a clear cut change.
So back to square one.
Posts: 6,684
Joined: Mar 2009
Reputation:
147
phil65
Retired Team-Kodi Member
Posts: 6,684
something similar should be done for slidercontrols, esp when they are two-sided (like in filter dialog). they are hard to use and do not allow a consistent navigation behaviour because they take onleft/onright actions.
and what about taking context menu instead of DialogSelect? that menu does not have that "empty space" problem. (would need c++ work though)
Posts: 201
Joined: May 2010
Reputation:
4
I completely agree with that. The dialog should auto-resize unless requested otherwise by the skin. If I wanted a centered full screen dialog that should be possible too.
Posts: 31,445
Joined: Jan 2011
I'd rather live with the occasional wasted space than have to scroll through 20 options with spin control. The lesser of two evils, ya know.