[menakite]

I was wondering about:

Code:

g_windowManager.GetTopMostModalDialogID() == WINDOW_DIALOG_BUSY

although I think it wasn't always behaving as I expected.

Looks fine here, however:

Code:

m_pPlayer->IsPlaying() && !m_pPlayer->IsCaching()

seems better as DialogBusy is massively used elsewhere (e.g. slow plugins - not all skins, like Amber, have a visual feedback).

It becomes true here:

Code:

2014-12-25 01:43:40.757 kodi.bin[7951:18084591] Debug Print: ------ Window Init (DialogBusy.xml) ------
2014-12-25 01:43:40.758 kodi.bin[7951:18084591] Debug Print: Window DialogBusy.xml was already loaded
2014-12-25 01:43:40.758 kodi.bin[7951:18084591] Debug Print: Alloc resources: 0.01m
2014-12-25 01:43:40.760 kodi.bin[7951:18084591] Debug Print: ScreenSaverDisablesAutoScrolling: playing !caching

and then false after:

Code:

2014-12-25 01:43:43.699 kodi.bin[7951:18084591] Debug Print: ------ Window Deinit (DialogBusy.xml) ------
2014-12-25 01:43:43.699 kodi.bin[7951:18084591] Debug Print: PlayFile: OpenFile succeed, play state 2
2014-12-25 01:43:43.700 kodi.bin[7951:18084591] Debug Print: OnPlayBackStarted: play state was 2, starting 0
2014-12-25 01:43:43.701 kodi.bin[7951:18084591] Debug Print: ScreenSaverDisablesAutoScrolling: playing !caching
2014-12-25 01:43:43.705 kodi.bin[7951:18094813] Debug Print: CDVDPlayer::SetCaching - caching state 0

I have to say that I'm not sure what this "caching state" is all about - it's not the file cache (could it return true while playing so that if you press "i" and the skin shows the plot is stops scrolling when it shouldn't?).

Edit: in fact it does. This works better:

Code:

m_pPlayer->IsPlaying() && g_windowManager.IsWindowActive(WINDOW_DIALOG_BUSY)

I honestly can't tell if it makes any difference and how noticeable that would be (has little to no effect at all on OS X).