Kodi DSPlayer – DirectShow Player for Windows
(2015-11-26, 12:25)sat4all Wrote:
Quote:Kodi-Team dev 2015-11-17:
DSPlayer's sources will certainly never hit our main repository. That should be clear from reading post #1 of this thread. The goal is to componentize and not adding more very platform specific code that is hard to maintain.

I haven't seen you "aracnoz" contributing a single line of code to our code base.

which happend to be the same day aracnoz stopped pushing commits (Latest commit 333771b 9 days ago)

so guess for what reason he left...

So - what is wrong with that statement in the given context? I took the time (last 30 minutes) and read through the commits on github - it's a huge load of #ifdeffery and callbacks that spams our whole implementation. It fully does the opposite of the cleanup that is ongoing since 2 years. This FernetMenta is pointing out - and I also cannot find a single PullRequest on our github.

Here is the fullquote of the first post:
FernetMenta Wrote:Kodi's video player is one of the oldest and most important components of the application. New features and ports to new platforms have long outgrown the original architecture of player. From its internal name "dvdplayer" you can tell how old this component is. In order to cope with current and future requirements like Ultra HD, MVC, 10bit depth, or PiP some elementary changes need to be done. The problem is that those changes require adjustments of platform dependent code. This dependency tremendously slows down development.

Ideally video player is a self contained component or service with its own life cycle and versioning. This would allow updates and upgrades independently from the main application. One platform could choose to stay with version X while others go with version Y. Maybe video player itself will be comprised of services with its own versions: decoders, demuxers, video/audio renderers, etc.

This is a long way and we need to get started somewhere. I requested this sub-forum to get platform devs involved, document and discuss what has been done so far, next steps, etc.

fritsch Wrote:So - what is wrong with that statement in the given context? I took the time (last 30 minutes) and read through the commits on github - it's a huge load of #ifdeffery and callbacks that spams our whole implementation. It fully does the opposite of the cleanup that is ongoing since 2 years.

It was made and done with a single purpose in mind - getting dsplayer working for windows, windows, windows only - while ignoring everything else in that code. DSPlayer made kodi to a windows player only - with only this platform in mind, implemented without the design goal to extend it to anywhere ...

So - yes - it belongs where it is - in the fork. Kodi has another goal as DSplayer has.

Edit: Btw. you should read the complete thread, including the conversation between Madshi and FernetMenta. There seems to be a really good understanding between them ...
First decide what functions / features you expect from a system. Then decide for the hardware. Don't waste your money on crap.
Reply


Messages In This Thread
Lockup on STOP issue resolved! - by MKANET - 2015-04-11, 21:59
RE: 4G aware patch - by MagikMark - 2015-09-08, 03:27
Alt-F4 no longer quits - by JeffA - 2015-10-31, 20:38
RE: Kodi DSPlayer – DirectShow Player for Windows - by fritsch - 2015-11-26, 12:33
H265 playback - by rew88 - 2017-11-04, 00:41
RE: H265 playback - by ashlar - 2017-11-04, 16:21
RE: H265 playback - by rew88 - 2017-11-05, 01:34
RE: H265 playback - by ashlar - 2017-11-05, 16:48
RE: H265 playback - by rew88 - 2017-11-05, 23:08
RE: H265 playback - by ashlar - 2017-11-06, 12:00
Leia 18 - by terpsarlington - 2017-11-21, 03:51
RE: Leia 18 - by spencerjford - 2017-11-21, 06:24
Display Modes / Refresh Rates - by goofer69 - 2019-09-20, 00:19
RE: Display Modes / Refresh Rates - by ashlar - 2019-09-20, 00:39
RE: Display Modes / Refresh Rates - by ashlar - 2019-09-20, 19:35
DSPlayer 23.810 to 23.976 - by Runakanta - 2018-05-09, 03:24
RE: DSPlayer 23.810 to 23.976 - by Warner306 - 2018-05-10, 01:32
Logout Mark Read Team Forum Stats Members Help
Kodi DSPlayer – DirectShow Player for Windows47