Kodi DSPlayer – DirectShow Player for Windows
(2017-09-12, 18:11)lexiconman Wrote:
(2017-09-11, 16:13)lexiconman Wrote: To (possibly) help troubleshoot, the issue seems to be that DSPlayer isn't engaging Fullscreen Exclusive mode for 3D content. Here are the interactions between screen resolutions:

Desktop/Kodi Resolution: 2160p
2D 1080p content - Desktop res stays 2160p, engages FSE D3D11, scales content to 2160p. Looks great.
3D - Desktop res auto switches to 1080p FP, plays D3D11 windowed mode, regardless of setting configuration, scales content to 2160, filling the 1080p screen with just the top left of the movie.

Desktop/Kodi Resolution: 1080p
2D 1080p content - Desktop switches to 2160p, D3D11 windowed mode, movie stays (i.e., doesn't scale) 1080p, and only fills up the top left portion of the screen. Looks like a picture in picture.
3D - Desktop stays 1080p (but activates 3d settings), movie plays in D3D11 windowed, movie isn't scaled so would look fine, but usually causes Kodi to crash after a little while.

I'm on Windows 8.1, GTX 1070 (having downgraded from Windows 10 on Madshi's recommendation).


More info regarding the above. Madshi seems to agree with my assessment (it's a Kodi bug). Hope this helps.

https://forum.doom9.org/showthread.php?p...ost1818110

Yes it's definitively a DSPlayer/KODI bug. I had a quick look at the source code and found a workaround .

Code:
diff --git "a/C:\\Users\\bjoern\\AppData\\Local\\Temp\\TortoiseGit\\WinEventsWin32-da9656c.000.cpp" "b/C:\\Users\\bjoern\\AppData\\Local\\Temp\\TortoiseGit\\WinEventsWin32-7581f44.000.cpp"
index a73f4bb3eb..c51f371aed 100644
--- "a/C:\\Users\\bjoern\\AppData\\Local\\Temp\\TortoiseGit\\WinEventsWin32-da9656c.000.cpp"
+++ "b/C:\\Users\\bjoern\\AppData\\Local\\Temp\\TortoiseGit\\WinEventsWin32-7581f44.000.cpp"
@@ -720,10 +720,6 @@ LRESULT CALLBACK CWinEventsWin32::WndProc(HWND hWnd, UINT uMsg, WPARAM wParam, L
       CLog::Log(LOGDEBUG, __FUNCTION__": display change event");  
       if (g_application.GetRenderGUI() && !g_Windowing.IsAlteringWindow() && GET_X_LPARAM(lParam) > 0 && GET_Y_LPARAM(lParam) > 0)  
       {
-#ifdef HAS_DS_PLAYER
-        if (g_application.m_pPlayer->GetCurrentPlayer() == "DSPlayer")
-          return(0);
-#endif
         g_Windowing.UpdateResolutions();
         if (g_advancedSettings.m_fullScreen)  
         {

The patch works for me if I disable Settings/System/Use fullscreen window. As mentioned above this is only a workaround. For a clean fix more adjustments have to be made.

Here is the binary: http://www.mediafire.com/file/e5dba2cmkf...er-x86.exe
Reply


Messages In This Thread
Lockup on STOP issue resolved! - by MKANET - 2015-04-11, 21:59
RE: 4G aware patch - by MagikMark - 2015-09-08, 03:27
Alt-F4 no longer quits - by JeffA - 2015-10-31, 20:38
RE: Kodi DSPlayer – DirectShow Player for Windows - by Tereius - 2017-09-19, 11:55
H265 playback - by rew88 - 2017-11-04, 00:41
RE: H265 playback - by ashlar - 2017-11-04, 16:21
RE: H265 playback - by rew88 - 2017-11-05, 01:34
RE: H265 playback - by ashlar - 2017-11-05, 16:48
RE: H265 playback - by rew88 - 2017-11-05, 23:08
RE: H265 playback - by ashlar - 2017-11-06, 12:00
Leia 18 - by terpsarlington - 2017-11-21, 03:51
RE: Leia 18 - by spencerjford - 2017-11-21, 06:24
Display Modes / Refresh Rates - by goofer69 - 2019-09-20, 00:19
RE: Display Modes / Refresh Rates - by ashlar - 2019-09-20, 00:39
RE: Display Modes / Refresh Rates - by ashlar - 2019-09-20, 19:35
DSPlayer 23.810 to 23.976 - by Runakanta - 2018-05-09, 03:24
RE: DSPlayer 23.810 to 23.976 - by Warner306 - 2018-05-10, 01:32
Logout Mark Read Team Forum Stats Members Help
Kodi DSPlayer – DirectShow Player for Windows47