Kodi DSPlayer – DirectShow Player for Windows
(2019-11-12, 20:39)Warner306 Wrote:
(2019-11-12, 16:22)fandangos Wrote: Tried to compile and of course it needs a lot of work. 

The good part is that now it's on github anyone can download, try to compile and work on it. 
I've started with small fixes and I encourage anyone to do so.

What isn't working after merging? Do you think you made a mistake when correcting some of the merge conflicts or are there new bugs that weren't there previously? Or it wouldn't compile after merging?

Even if you can't get it working, you small effort is appreciated.  
It's giving tons of errors to compile. 
After you solve 600 merge conflicts (which I wouldn't say is small but to each their own) by hand there are still a lot of work to do. 
Merging without any problems just means part of the code, or previews github commits are not conflicting with each other. 

All changelogs where having merge conflicts because they would have a lot of code on top of the existing in DSPlayer file and could have something like "delete first line", which would result in a conflict. 
Hard to explain but easy to understand in pratice. 

I'll give one example of a error that prevents it to compile:
This commit I made today solved one error:
https://github.com/fandangos2/xbmc/commi...8d20c3585d

add_platform_override does not exist in CMake anymore. That means it merged sucessfuly but the code doesn't exist and are not used by kodi anymore.

Fixing unneded stuff is quite easy, you just look at the error and follow the line and just understand that this isn't necessary anymore based on the code used by team kodi today. 

The hardest part is translation. Many and I mean many ways to call a function changed or became part of something else. 
When working on the code I've see something like gWindowing becoming Windowing:Confusedomething. 
So everytime DSPlayer calls this kind of function or some left over from Krypton is present you need to delete it (in case of old Krypton stuff) or translate to what is used today hopefully the function would still exist but with a different name. 

And finally DSPlayer have several files of it's own, that means that if Krypton code is updated by the merge, those are not, so all old function names and classes and such need to be updated or translated.

By the way, as I've stated several times I'm no experient dev so maybe I'm using wrong terms and such but this is how I understand the work that still needs to be done.
Reply


Messages In This Thread
Lockup on STOP issue resolved! - by MKANET - 2015-04-11, 21:59
RE: 4G aware patch - by MagikMark - 2015-09-08, 03:27
Alt-F4 no longer quits - by JeffA - 2015-10-31, 20:38
H265 playback - by rew88 - 2017-11-04, 00:41
RE: H265 playback - by ashlar - 2017-11-04, 16:21
RE: H265 playback - by rew88 - 2017-11-05, 01:34
RE: H265 playback - by ashlar - 2017-11-05, 16:48
RE: H265 playback - by rew88 - 2017-11-05, 23:08
RE: H265 playback - by ashlar - 2017-11-06, 12:00
Leia 18 - by terpsarlington - 2017-11-21, 03:51
RE: Leia 18 - by spencerjford - 2017-11-21, 06:24
Display Modes / Refresh Rates - by goofer69 - 2019-09-20, 00:19
RE: Display Modes / Refresh Rates - by ashlar - 2019-09-20, 00:39
RE: Display Modes / Refresh Rates - by ashlar - 2019-09-20, 19:35
RE: Kodi DSPlayer – DirectShow Player for Windows - by fandangos - 2019-11-12, 21:20
DSPlayer 23.810 to 23.976 - by Runakanta - 2018-05-09, 03:24
RE: DSPlayer 23.810 to 23.976 - by Warner306 - 2018-05-10, 01:32
Logout Mark Read Team Forum Stats Members Help
Kodi DSPlayer – DirectShow Player for Windows47