@
janbar - many thanks for your detailed reply, it was just what I hoped for
. doityourself it is. If you can avoid force pushes, it will make my life much easier!
@
MikeB2013, thanks for your comments.
@janbar I will try and answer your questions. If I am unclear, please say:
1. I want to change 'channel' for an existing rule without affecting recorded show.
Rule EPG tag code matches by channel/time, then over-rides Title. Not good for +1/+24 channels.
2. ST_NoSearch rules don't need an EPG entry. RT_DailyRecord, RT_WeeklyRecord, RT_OneRecord and RT_AllRecord all match using 'Title'.
Duplicate checking uses ProgramID, Title, Subtitle and Description.
'This Series' filter uses SeriesID, not an EPG entry. ( See
https://www.mythtv.org/wiki/Recordfilter_table ).
An EPG entry is needed to populate ProgramID and SeriesID (PVR_TIMER_REQURIES_EPG_TAG_ON_CREATE), but is then not necessary. I have alternative logic for NewFromTimer (UpdateFromTimer) for all existing timer types which works well without needing an EPG TAG on modify.
3. OK. Like the approach, will do.
4. Yes.
5. Yes. All missing places where 'subtitle' needs to be displayed are included in the API3.0.0 commit.
6. With my working code only Weekly and Daily rules use ST_TitleSearch (when 'AnyTime' is set). This uses 'title'. Search Keyword and Search People use ST_XXXXSearch but using 'strEpgSearchString'. I don't think this makes for 'unreadable' code, but yes, a separate PR is a very good idea.
7. Benefits: a) makes the UI more like Mythfrontend / mythweb, b) uses the Kodi API 'properly' (i.a.w. doxy). Not major benefits I agree and I haven't fully tested this yet, so maybe I will change my mind when I finish implementing a prototype.
8. @
MikeB2013 is right, I mean the (optional) user defined recording templates. I haven't prototyped this yet, so I am not sure exactly how it should work. Still at the very least the user should be able to select which recording template to use in the addon configure dialog: addon provided, Mythtv "Default" or Mythtv "<select from list>".
9. I don't want to waste time PRing changes no one else wants! If Record Series is essential, let's keep it.
@MikeB2013 - Managing rules created/modified outside kodi is a key part of my philosophy:
- Simple timer types, similar to those available in Mythweb.
- Create new rules using (in priority order) a) timer settings dialog values, b) EPG TAG data, c) the chosen rule template.
- When editing a rule, only change what can be edited on the timer settings dialog (changes 1/2/3). Anything which can't be displayed won't be changed by Kodi.
- One-One mapping: backend rule <-> timer type.
- Only use 'unhandled' for rule types which Kodi can't edit properly (PowerSearch)
I would really like to be able to provide a 'summary' of all the settings a rule has which don't display in the timer settings dialog. Maybe 'strSummary' could be used for this, but it would require another Kodi PVR core change. Something for the future IMHO.