[Milhouse]

I'm having an issue with the trakt add-on since build #0910.

I've described the issue in a private discussion with the author (razze): https://teamkodi.slack.com/archives/gene...5885005656 (Team members only), see 02:34
Basically, I have it configured to rate videos after watching. It shows a custom dialog to do so and then waits for the user to rate it or close the dialog.
Since build #0910 the dialog is not shown, but the add-on thinks it is and then sits there indefinitely, so it basically stop working (scrobble, manual sync, etc. It really is waiting for the dialog). GUI is fully usable as no dialog is shown at all.
It might need a few tries to reproduce (you can fast forward near the end).

Seems a bit difficult to track it down, as build #0910 has lots of commits and files changed, but you guys might have an idea...

Edit: the dialog I'm talking about is this:
https://github.com/trakt/script.trakt/bl...ing.py#L97
https://github.com/trakt/script.trakt/bl...ng.py#L154

I've rebuilt #0910 and reproduced the issue. I then reverted PR7800, rebuilt #0910, and now the trakt rating is working. The only difference between the two builds being the presence or omission of PR7800.

Here are the debug logs when watching Falling Skies 5x10, seeking to the end, and then waiting for the Trakt Rating dialog to appear:
#0910a - with PR7800, dialog doesn't appear
#0910b - without PR7800, dialog does appear

This is the part in the debug log where the non-working build #0910a attempts to load the Ratings dialog:

Code:

11:39:43  45.365074 T:1966022656   DEBUG: ------ Window Init (/storage/.kodi/addons/script.trakt/resources/skins/Default/720p/script-trakt-RatingDialog.xml) ------
11:39:43  45.365250 T:1966022656    INFO: Loading skin file: /storage/.kodi/addons/script.trakt/resources/skins/Default/720p/script-trakt-RatingDialog.xml, load type: LOAD_ON_GUI_INIT
11:39:43  45.384960 T:1966022656   DEBUG: POParser: loaded 157 strings from file /storage/.kodi/addons/script.trakt/resources/language/English/strings.po
11:39:44  45.401741 T:1966022656   DEBUG: SECTION:LoadDLL(special://xbmcbin/system/ImageLib-arm.so)
11:39:44  45.402008 T:1966022656   DEBUG: Loading: /usr/lib/kodi/system/ImageLib-arm.so
11:39:44  45.466091 T:1966022656   DEBUG: CGUIMediaWindow::GetDirectory ()
11:39:44  45.466255 T:1966022656   DEBUG:   ParentPath = []
11:39:44  45.505447 T:1966022656   DEBUG: ------ Window Deinit () ------
11:39:44  45.505634 T:1966022656   DEBUG: ------ Window Deinit (/storage/.kodi/addons/script.trakt/resources/skins/Default/720p/script-trakt-RatingDialog.xml) ------
11:39:44  45.538445 T:1966022656   DEBUG: ------ Window Init () ------
11:39:46  48.181763 T:1838150656   DEBUG: POParser: loaded 157 strings from file /storage/.kodi/addons/script.trakt/resources/language/English/strings.po

And the same in build #0910b, which is working - I didn't set a rating in the Ratings dialog (clicked the "Back" button on my remote)

Code:

11:42:58  80.103386 T:1966514176   DEBUG: ------ Window Deinit () ------
11:42:58  80.103561 T:1966514176   DEBUG: ------ Window Init (/storage/.kodi/addons/script.trakt/resources/skins/Default/720p/script-trakt-RatingDialog.xml) ------
11:42:58  80.103683 T:1966514176    INFO: Loading skin file: /storage/.kodi/addons/script.trakt/resources/skins/Default/720p/script-trakt-RatingDialog.xml, load type: LOAD_ON_GUI_INIT
11:42:58  80.123070 T:1966514176   DEBUG: POParser: loaded 157 strings from file /storage/.kodi/addons/script.trakt/resources/language/English/strings.po
11:42:58  80.139923 T:1966514176   DEBUG: SECTION:LoadDLL(special://xbmcbin/system/ImageLib-arm.so)
11:42:58  80.140236 T:1966514176   DEBUG: Loading: /usr/lib/kodi/system/ImageLib-arm.so
11:42:58  80.203163 T:1966514176   DEBUG: CGUIMediaWindow::GetDirectory ()
11:42:58  80.203362 T:1966514176   DEBUG:   ParentPath = []
11:42:58  80.242615 T:1966514176   DEBUG: ------ Window Init () ------
11:43:01  82.990295 T:1838150656   DEBUG: POParser: loaded 157 strings from file /storage/.kodi/addons/script.trakt/resources/language/English/strings.po
11:43:07  89.031746 T:1966514176   DEBUG: LIRC: Update - NEW at 81429:ae 0 KEY_EXIT devinput (KEY_EXIT)
11:43:07  89.032066 T:1966514176   DEBUG: OnKey: menu (0xd8) pressed, action is ParentDir
11:43:07  89.064400 T:1838150656   DEBUG: [script.trakt] rating: Rating dialog was closed with no rating.
11:43:07  89.065704 T:1966514176   DEBUG: LIRC: Update - NEW at 81463:ae 0 KEY_EXIT_UP devinput (KEY_EXIT_UP)
11:43:07  89.405533 T:1966514176   DEBUG: ------ Window Deinit (/storage/.kodi/addons/script.trakt/resources/skins/Default/720p/script-trakt-RatingDialog.xml) ------

The non-working version (with PR7800) seems to perform a "Window Deinit ()" on the Ratings dialog without actually displaying it, which presumably the add-on is unaware of and so it waits for input that never comes - either a bug introduced by PR7800, or a new behaviour in Kodi which the addon now needs to take account of?