[zachmorris]

Hey Zach,

Thanks for the great work your doing here!

I have one problem with the addon and would like your help:

MS-DOS games do not download (0kb) when login is enabled (also no warning screen). If login is disabled it workes fine but it wont download other games like for the PSX because they need a login.

Below is a part of the debug log. If you need a full log let me know.

Code:

13:19:05.672 T:7760  NOTICE: IARL:  Download and Launch started for Oregon Trail, The
13:19:05.674 T:7760   DEBUG: IARL:  Loading history cache C:\Users\pimve\AppData\Roaming\Kodi\userdata\addon_data\plugin.program.iarl\list_cache\iarl_history.pickle
13:19:05.685 T:7760   DEBUG: IARL:  List cached to file C:\Users\pimve\AppData\Roaming\Kodi\userdata\addon_data\plugin.program.iarl\list_cache\iarl_history.pickle
13:19:05.685 T:7760  NOTICE: IARL:  Download started for Oregon Trail, The
13:19:05.688 T:7760   DEBUG: IARL:  No matching file found for D:\Games\Retro Games\Oregon_Trail_The_1990.zip
13:19:05.688 T:7760   DEBUG: DialogProgress::Open called
13:19:05.688 T:7760   DEBUG: ------ Window Init (DialogConfirm.xml) ------
13:19:05.688 T:7760    INFO: Loading skin file: DialogConfirm.xml, load type: KEEP_IN_MEMORY
13:19:09.060 T:7760   DEBUG: IARL:  Download with login URL: https://archive.org/download/msdos_Oregon_Trail_The_1990/Oregon_Trail_The_1990.zip
13:19:09.060 T:7760   DEBUG: IARL:  Download save filename: D:\Games\Retro Games\Oregon_Trail_The_1990.zip
13:19:10.449 T:7760   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.ZeroDivisionError'>
                                            Error Contents: float division by zero
                                            Traceback (most recent call last):
                                              File "C:\Users\pimve\AppData\Roaming\Kodi\addons\plugin.program.iarl\addon.py", line 1825, in onClick
                                                download_and_launch_rom(self,iarl_data)
                                              File "C:\Users\pimve\AppData\Roaming\Kodi\addons\plugin.program.iarl\addon.py", line 1559, in download_and_launch_rom
                                                iarl_data['current_save_data'] = download_rom_only(iarl_data)
                                              File "C:\Users\pimve\AppData\Roaming\Kodi\addons\plugin.program.iarl\addon.py", line 1126, in download_rom_only
                                                iarl_data['current_save_data']['rom_save_filenames_success'][ii] = download_tools().Downloader(quote_url(iarl_data['current_rom_data']['rom_filenames'][ii]),iarl_data['current_rom_data']['rom_save_filenames'][ii],iarl_data['settings']['ia_enable_login'],iarl_data['settings']['ia_username'],iarl_data['settings']['ia_password'],iarl_data['current_rom_data']['rom_size'][ii],iarl_data['current_rom_data']['rom_title'],'Downloading, please wait...')
                                              File "C:\Users\pimve\AppData\Roaming\Kodi\addons\plugin.program.iarl\resources\lib\webutils.py", line 60, in Downloader
                                                percent = 100.0 * size / est_filesize
                                            ZeroDivisionError: float division by zero
                                            -->End of Python script error report<--
13:19:10.669 T:3084   DEBUG: ------ Window Deinit (DialogConfirm.xml) ------
13:19:10.683 T:3084   DEBUG: ------ Window Deinit (Pointer.xml) ------
13:19:15.291 T:3084   DEBUG: ------ Window Init (Pointer.xml) ------
13:19:17.011 T:3084   DEBUG: CInputManager::ProcessMouse: trying mouse action leftclick
13:19:17.027 T:3084   DEBUG: ------ Window Deinit (C:\Users\pimve\AppData\Roaming\Kodi\addons\plugin.program.iarl\resources\skins\Default\720p\default.xml) ------
13:19:17.030 T:7760    INFO: CPythonInvoker(4, C:\Users\pimve\AppData\Roaming\Kodi\addons\plugin.program.iarl\addon.py): script successfully run
13:19:17.044 T:3084   ERROR: XFILE::CDirectory::GetDirectory - Error getting plugin://plugin.program.iarl/Emulator/IA_MSDOS_ZachMorris/Game/Oregon+Trail%2C+The
13:19:17.044 T:3084   ERROR: CGUIMediaWindow::GetDirectory(plugin://plugin.program.iarl/Emulator/IA_MSDOS_ZachMorris/Game/Oregon+Trail%2C+The) failed
13:19:17.045 T:3084   DEBUG: CGUIMediaWindow::GetDirectory (plugin://plugin.program.iarl/Emulator/IA_MSDOS_ZachMorris/1)
13:19:17.045 T:3084   DEBUG:   ParentPath = [plugin://plugin.program.iarl/]
13:19:17.048 T:7760    INFO: Python script stopped

Thanks!

Thanks PimmoZ, looks like a silly divide by zero bug. I'll fix that for the next update. Thanks for the report.