[zachmorris]

Hi Zach,

while playing with the addon, I have noticed the following things:

1)  When one presses the Close Button on the Game Launch Window, the Addon sends a command to the video player to stop playing the video.
2)  When one plays the trailer , the trailer button disappear and the stop button appears, but if one lets the trailer play until the end (without clicking on the stop button), the stop button does not revert to the trailer button.

Here my Suggestions:

regarding 1)
simply close the window and do not stop the video, remember that the user may be using the video player for other things while browsing the addon, for example watching a movie or live tv.
Currently the following could happen:
- User is watching a movie
- he enters your addon and browses through the games
- he opens the launch window, but then decides he does not want to play, so he closes the window
- His movie is stopped by your addon

regarding 2)
- The trailer button should not have any dependency with the Stop button
- The trailer button should always be visible and every time you click it, the trailer should start
- the skinner shall be responsible for providing the user with an option to stop playback (most skins have this and is also possible to do it with the remote control and keyboard)
- since you provide a default window, you can add a stop button for your window with the following visibility condition <visible>Player.HasVideo</visible>, this way the user of your default window can stop the playback of any video that is currently being played by kodi.

Thanks for your suggestions.  I think I got this all straightened out, almost all of the control and logic is transferred to the skin now rather than in the addon code which I think will fix most of the issues you were having.  The control of the game trailer in the skin was really confusing.  I ended up adding a variable to track if the trailer was selected to play or not.

I have pushed the changes to github, feel free to try this again and see if it works for your skin.  If there are other things that you think are needed to make this skin friendly please let me know.