2015-11-06, 10:54
Rather than clutter Git I would like to pull the discussion of this topic out onto the forum and a wider audience. I hope that some users see it here, although communicating with the average user is difficult.
Until Jarvis when using music file view if the files were songs then the tags were scanned and tag data displayed. Then PR8011 aiming to reduce the diversity of dialogs to simplify skinning and make music more like video, resulted in this tag data no longer being displayed. This loss in functionality was discussed in the middle of this thread http://forum.kodi.tv/showthread.php?tid=235259&pid=2129282#pid2129282, mixed up with other things. The conclusion was that until such a time as the function could be performed by the library the original functionality should be restored. I did just that in PR8205 and a better fix in PR8287.
However there are some devs that can not see the point in keeping an enriched music file view. They believe that music file view, just like video, should just be a list of folders and files and nothing more. It is a comment that came up post merge on both PRs. Personally I don't see why there is a desire to dumb-down Kodi, by removing useful functionality, but I am a new dev team member and could easily (and even reasonably) be voted out on this matter.
There may also still be flaws in my implementation of the fix, I'm not saying I did a great job just advocating that the functionality need to be provided.
So can we discuss it one more time, and be clear on what the issues and requirements are. I may try and summarise posts from the previous thread (or can someone merge the approriate posts?)
Until Jarvis when using music file view if the files were songs then the tags were scanned and tag data displayed. Then PR8011 aiming to reduce the diversity of dialogs to simplify skinning and make music more like video, resulted in this tag data no longer being displayed. This loss in functionality was discussed in the middle of this thread http://forum.kodi.tv/showthread.php?tid=235259&pid=2129282#pid2129282, mixed up with other things. The conclusion was that until such a time as the function could be performed by the library the original functionality should be restored. I did just that in PR8205 and a better fix in PR8287.
However there are some devs that can not see the point in keeping an enriched music file view. They believe that music file view, just like video, should just be a list of folders and files and nothing more. It is a comment that came up post merge on both PRs. Personally I don't see why there is a desire to dumb-down Kodi, by removing useful functionality, but I am a new dev team member and could easily (and even reasonably) be voted out on this matter.
There may also still be flaws in my implementation of the fix, I'm not saying I did a great job just advocating that the functionality need to be provided.
So can we discuss it one more time, and be clear on what the issues and requirements are. I may try and summarise posts from the previous thread (or can someone merge the approriate posts?)