• 1
  • 9
  • 10
  • 11(current)
  • 12
  • 13
  • 28
[RELEASE] FilmAffinity (Spanish) scraper
There's a tool called diff. It is a tool that can be used to create a diff (aka patch) that contains differences between two or more files. The most common format is the unified format as its easier to read and work with.

If you can't supply a diff, please make sure you modify the current scraper sitting in SVN so we can easily replace the existing one.
Always read the online manual (wiki), FAQ (wiki) and search the forum before posting.
Do not PM or e-mail Team-Kodi members directly asking for support. Read/follow the forum rules (wiki).
Please read the pages on troubleshooting (wiki) and bug reporting (wiki) before reporting issues.
Reply
vdrfan Wrote:There's a tool called diff. It is a tool that can be used to create a diff (aka patch) that contains differences between two or more files. The most common format is the unified format as its easier to read and work with.

If you can't supply a diff, please make sure you modify the current scraper sitting in SVN so we can easily replace the existing one.

I tried to find diff application but it is a common word to find it with google. can you give me a link to the application?

I will send aka patch once I install it.

Thanks!
HectorziN
Reply
uhm, windows? just grab tortoisesvn, it allows you to checkout stuff from svn (guarantee's latest version) and has a great diff tool (both for applying diffs and for generating them)
Reply
spiff Wrote:uhm, windows? just grab tortoisesvn, it allows you to checkout stuff from svn (guarantee's latest version) and has a great diff tool (both for applying diffs and for generating them)

I get this error trying to check out:

Checkout from http://trac.xbmc.org/export/22635/branch...xport/XBMC, revision HEAD, Fully recursive, Externals included
The OPTIONS response did not include the requested activity-collection-set
this often means that the URL is not WebDAV-enabled

what can be the problem?

thanks!
HectorziN
Reply
spiff Wrote:uhm, windows? just grab tortoisesvn, it allows you to checkout stuff from svn (guarantee's latest version) and has a great diff tool (both for applying diffs and for generating them)

I used Merge tool from tortoise and it shows me the differences but the option to generate diff file is deactivated.
I downloaded manually the file from xbmc/trac and did the comparison with both files from hard disk. I wasn't able to use checkou option
HectorziN
Reply
svn co https://xbmc.svn.sourceforge.net/svnroot...xport/XBMC

not the export url. also do your changes in the svn dir, THEN right click and select 'make patch'. that will give you a diff against the current file in svn
Reply
spiff Wrote:svn co https://xbmc.svn.sourceforge.net/svnroot...xport/XBMC

not the export url. also do your changes in the svn dir, THEN right click and select 'make patch'. that will give you a diff against the current file in svn

Thanks! it worked!

Is there a way to submit a patch directly using tortoise? or should I go to xbmc.org/trac and create a ticket? is there a way to checkout, change source and submit using only tortoise tools?
HectorziN
Reply
no, trac is not integrated, so you need to save it to a diff file, open a ticket and attach the file.
Reply
HectorziN Wrote:This patch cannot be submited because what he has done was remove includes and copy the include code inside the scraper.
The scraper is working, the problem is includes is a feature of latest versions of xbmc. The last scraper don't work with old xbmc versions.
[...]

Hello,

I had just taken my 9.04.1 scrapper in XBox (that's my last usable version) and almost blindly modifiy it (without understanding sometimes what I was writing or why you write other things) Smile That's the reason some unnecessary things were changed.

I had also noted that it is for revisions prior to include tags. Maybe scrapper fixes like this should be available to download separatly instead being "forced" to use the last SVN version :-?

I think you are also spanish so "Gracias" Smile
Reply
spiff Wrote:no, trac is not integrated, so you need to save it to a diff file, open a ticket and attach the file.

I sent it but I think has not been included.
HectorziN
Reply
Added in SVN r23161. Cheers!
Always read the online manual (wiki), FAQ (wiki) and search the forum before posting.
Do not PM or e-mail Team-Kodi members directly asking for support. Read/follow the forum rules (wiki).
Please read the pages on troubleshooting (wiki) and bug reporting (wiki) before reporting issues.
Reply
Sad 
After last changes in the scraper [SVN r23161], Fanart and posters distinct than Filmaffinity doesn't work No .

[Castellano]

Despues de ponerme el ultimo scraper [SVN r23161], los Fanart y los posters de otros sitios que no sean Filmaffinity no se muestran.

[/Castellano]

Sad
Reply
JoshyFun Wrote:Hello,

I had just taken my 9.04.1 scrapper in XBox (that's my last usable version) and almost blindly modifiy it (without understanding sometimes what I was writing or why you write other things) Smile That's the reason some unnecessary things were changed.

I had also noted that it is for revisions prior to include tags. Maybe scrapper fixes like this should be available to download separatly instead being "forced" to use the last SVN version :-?

I think you are also spanish so "Gracias" Smile
I'm glad to see you again JoshyFun. Thanks for this scrapper update.

Please contact me back.

bye!

pequesan_at_gmail.com
Reply
AlbertQ Wrote:After last changes in the scraper [SVN r23161], Fanart and posters distinct than Filmaffinity doesn't work No .

[Castellano]

Despues de ponerme el ultimo scraper [SVN r23161], los Fanart y los posters de otros sitios que no sean Filmaffinity no se muestran.

[/Castellano]

Sad

Download latest version of xbmc. Last scraper only works with last version.

Regards
HectorziN
Reply
JoshyFun Wrote:Hello,

I had just taken my 9.04.1 scrapper in XBox (that's my last usable version) and almost blindly modifiy it (without understanding sometimes what I was writing or why you write other things) Smile That's the reason some unnecessary things were changed.

I had also noted that it is for revisions prior to include tags. Maybe scrapper fixes like this should be available to download separatly instead being "forced" to use the last SVN version :-?

I think you are also spanish so "Gracias" Smile

You must understand that we must to maintain the last version, and not older version. Wink
HectorziN
Reply
  • 1
  • 9
  • 10
  • 11(current)
  • 12
  • 13
  • 28

Logout Mark Read Team Forum Stats Members Help
[RELEASE] FilmAffinity (Spanish) scraper2