API - deprecated features v18

  Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
MatthewLundberg Offline
Junior Member
Posts: 42
Joined: Apr 2017
Reputation: 0
Post: #31
Does this mean that the client function GetLiveStreamURL is also going away?

It sounds like the PVR is now required to handle the network IO for reading remote streams, as this could be previously specified by strStreamURL.

Assuming that this is correct, are there calls into Kodi that I can make to handle the networking? The HDHomeRun PVR is now using strStreamURl to specify the stream, which is opened by the *DVD* reader.
(This post was last modified: 2017-06-06 02:40 by MatthewLundberg.)
find quote
MatthewLundberg Offline
Junior Member
Posts: 42
Joined: Apr 2017
Reputation: 0
Post: #32
Partially answering my own question, it looks like I can create an object of type CDVDInputStreamFFmpeg, as in the function CDVDFactoryInputStream::CreateInputStream. Once I figure out how to build the CFileItem that it needs...

Can I call these functions from within the PVR code?
(This post was last modified: 2017-06-06 06:43 by MatthewLundberg.)
find quote
ksooo Offline
Team-Kodi Member
Posts: 814
Joined: Jan 2015
Reputation: 41
Location: Hamburg, Germany
Post: #33
(2017-06-06 06:10)MatthewLundberg Wrote:  Partially answering my own question, it looks like I can create an object of type CDVDInputStreamFFmpeg, as in the function CDVDFactoryInputStream::CreateInputStream. Once I figure out how to build the CFileItem that it needs...

Can I call these functions from within the PVR code?


Sorry, no. These classes/functions are not part of the official Kodi API, thus can change incompatible at any (!) random point in time, breaking your add-on.

You may want to take a look at kodi-platform, which provides stable basic functionality that can be used safely in kodi binary add-ons. => https://github.com/Pulse-Eight/platform
find quote
MatthewLundberg Offline
Junior Member
Posts: 42
Joined: Apr 2017
Reputation: 0
Post: #34
Thanks, ksooo, I am looking there. It appears to have everything that I will need.

I did notice though, that the P8PLATFORM::PreventCopy class does not allow moves. Is this code being actively maintained?
find quote
ksooo Offline
Team-Kodi Member
Posts: 814
Joined: Jan 2015
Reputation: 41
Location: Hamburg, Germany
Post: #35
As far as I know, yes.

@opdenkamp might have more insights.
find quote
MatthewLundberg Offline
Junior Member
Posts: 42
Joined: Apr 2017
Reputation: 0
Post: #36
Confirmed, it is easy to support ReadLiveStream, and I have done so in yet-to-be-pushed code. No more strStreamURL or ThisIsAHack calling GetLiveStreamURL. And maybe it's my imagination, but channel changes seem to be faster and smoother.

I do have a question about this though. In this thread, picture-in-picture is mentioned. However, the function for ReadLiveStream does not indicate a channel or any other handle to allow the PVR to supply multiple streams. Is picture-in-picture only supported for two instances of the PVR, or for the PVR and another stream (say, from a file)?
(This post was last modified: 2017-06-07 05:23 by MatthewLundberg.)
find quote
ksooo Offline
Team-Kodi Member
Posts: 814
Joined: Jan 2015
Reputation: 41
Location: Hamburg, Germany
Post: #37
(2017-06-07 05:20)MatthewLundberg Wrote:  Confirmed, it is easy to support ReadLiveStream, and I have done so in yet-to-be-pushed code. No more strStreamURL or ThisIsAHack calling GetLiveStreamURL. And maybe it's my imagination, but channel changes seem to be faster and smoother.

I do have a question about this though. In this thread, picture-in-picture is mentioned. However, the function for ReadLiveStream does not indicate a channel or any other handle to allow the PVR to supply multiple streams. Is picture-in-picture only supported for two instances of the PVR, or for the PVR and another stream (say, from a file)?


PIP is currently not supported at all. Larger changes in Kodi core and add-ons (including API) are required for this. We're working on this, but still a long way to go, no release date scheduled so far.
find quote
rbuehlma Online
Junior Member
Posts: 49
Joined: Aug 2014
Reputation: 3
Post: #38
(2017-06-07 05:20)MatthewLundberg Wrote:  Confirmed, it is easy to support ReadLiveStream, and I have done so in yet-to-be-pushed code. No more strStreamURL or ThisIsAHack calling GetLiveStreamURL. And maybe it's my imagination, but channel changes seem to be faster and smoother.

Do you know if that would also work for streams which should be handled by an inputstream addon (e.g. a DASH stream)?
find quote
MatthewLundberg Offline
Junior Member
Posts: 42
Joined: Apr 2017
Reputation: 0
Post: #39
I don't know what a DASH stream is. It would probably work for the simple IPTV addon, on which the first version of the HDHomeRun PVR is based.

See here: https://github.com/MatthewLundberg/pvr.h...e5bdb440c0
find quote
Post Reply