• 1
  • 17
  • 18
  • 19(current)
  • 20
  • 21
  • 24
Release CleanSubs - (Clean subtitles from the ads and other rubbish)
v6.18...

hopefully fixed for interactive cleaning and smb://

Sorry for doing this bit-by-bit, I simply don't have enough time Smile
Reply
The interactive cleaning does work now on Android with SMB! Excellent work DaLanik!
Greetz
cgi2011
Reply
Great. I'll have to do it as well for library and folder cleaning as well Smile
Reply
v6.19 in the test repo.

Hopefully a solution for all nfs:// and smb:// paths in the whole addon: interactive cleaning, folder cleaning and library cleaning. If someone can test with smb and nfs and let me know so I can move to regular repo.
Reply
I just installed 6.19, how can I force the folder and library cleaning?

Greetz
Reply
You just run the addon - it should be visible under addon-programs and select what should be cleaned
Reply
(2017-09-07, 18:30)DaLanik Wrote: v6.19 in the test repo.

Hopefully a solution for all nfs:// and smb:// paths in the whole addon: interactive cleaning, folder cleaning and library cleaning. If someone can test with smb and nfs and let me know so I can move to regular repo.

Thanks for your work and sorry for the late reply.

There's this little annoyance though and I don't know if CS is to blame (or something else), but it occurred when CS started to work:

So I've downloaded a sub and it gets cleaned, Whenever I've stop playing in the middle of the video and I want to restart the video (to play where I've left off), subtitles have been disabled. I need to manually enable them using Kodi's playercontrols bar or the audio settings window. Even when in the audio setting window when I tell the system to enable subtitles for all video's, the next time I stop and replay, subtitles are disabled again.
Reply
I'll test it, is shouldn't do that. It disables subtitles right before clean, but ENABLES when done - how else would they be displayed? It is beyond me why it would do that.

Is it only for SAME video? Do you play, stop, and then LATER play again same video?

What about when you play different one?
Reply
Initially I thought it was for the same video. However, I'm not the only one operating Kodi and my wife just doesn't notice subs are disabled automatically.

It appears subtitles are disabled globally for every video after using CleanSubs. An example:
In order to reply correctly for this post, I started a new series episode, which shouldn't have any subtitles yet. When started, I noticed the Autosubs add-on didn't kick in to present me with a list of subtitles to download. But in fact, the episode already had subtitles. It didn't display them because the Kodi control bar showed that subtitles where disabled again.

That explains why the auto-subs addon sometimes does not kick in, because it doesn't need to. Subs are there, but just not shown.

Anyway, I've downloaded a new subtitle for that new episode, which got cleaned and subsequently subtitles where displayed. But when stopping that same video after 5 minutes and playing it again, subtitles where disabled again. This is the same for the next video and the next............until CleanSubs is used once again. After that it will show subtitles for that show only (if not stopped in the middle)
Reply
Just tried and no, it doesn't disable subtitles. Here is the log, with autosubs enabled kicking in immediately after I start video:

Code:
13:56:32 T:11932  NOTICE: CLEANSUBS >> STARTED VERSION 6.19
13:56:32 T:11932  NOTICE: CLEANSUBS >> DEFINITIONS >> NO NEW DEFINITIONS (L:27150 == R:27150)
13:56:32 T:11932  NOTICE: CLEANSUBS >> SETTING ON >> True
13:56:32 T:11932  NOTICE: CLEANSUBS >> SETTING INFO >> True
13:56:32 T:11932  NOTICE: CLEANSUBS >> SETTING LOGO >> True
13:56:32 T:11932  NOTICE: CLEANSUBS >> SETTING FOLDER >> D:\My Documents\Videos\
13:56:32 T:11932  NOTICE: CLEANSUBS >> SETTING CUSTOM DEF >> True
13:56:32 T:11932  NOTICE: CLEANSUBS >> SETTING REMOVE CC >> True
13:56:32 T:11932  NOTICE: CLEANSUBS >> SETTING REMOVE TAGS >> True
13:56:32 T:11932  NOTICE: CLEANSUBS >> SETTING SUBS BACKGROUND >> True
13:56:32 T:11932  NOTICE: CLEANSUBS >> SETTING SUBS BACKGROUND TXT COLOR >> cba7ff
13:56:32 T:11932  NOTICE: CLEANSUBS >> SETTING METHOD >> 0
13:56:32 T:11932  NOTICE: CLEANSUBS >> SETTING HEURISTICS LINES NR >> 2
13:56:32 T:11932  NOTICE: CLEANSUBS >> SETTING DELETE ORIGINAL SUBS >> True
13:56:32 T:11932  NOTICE: CLEANSUBS >> SETTING SUBFIRST >> False
13:56:32 T:11932  NOTICE: CLEANSUBS >> SETTING CHARSET >> CP1250
13:56:32 T:11932  NOTICE: CLEANSUBS >> SETTING SUB LANGUAGES: >>CZECH<<
13:56:32 T:11932  NOTICE: CLEANSUBS >> SETTING SUB LANGUAGES: >>ENGLISH<<
13:56:32 T:11932  NOTICE: CLEANSUBS >> SETTING SUB LANGUAGES: >>SERBO-CROATIAN<<
13:56:32 T:11932  NOTICE: CLEANSUBS >> SETTING SUB LANGUAGES: >>GENERIC<<
13:56:32 T:11932  NOTICE: CLEANSUBS >> USING TOTAL DEFINITIONS: 656 elements
13:56:34 T:11932  NOTICE: CLEANSUBS >> UUID is 54d5e40d
13:56:55 T:11932  NOTICE: CLEANSUBS >> SQL ERROR IN SyncUUID1: 2003: Can't connect to MySQL server
13:56:55 T:11932  NOTICE: CLEANSUBS >> SQLITE ERROR IN MAIN
13:56:55 T:11932  NOTICE: CLEANSUBS >> NO RECORDS IN LOCAL DB
13:56:55 T:11932  NOTICE: CLEANSUBS >> REMOVED PYO
14:01:56 T:11932  NOTICE: CLEANSUBS >> LAST RUN 5 MINUTES AGO
14:04:59 T:11932  NOTICE: CLEANSUBS >> PLAYBACK >>PLAYING<<
14:04:59 T:11932  NOTICE: CLEANSUBS >> EXSUBS: False
14:04:59 T:11932  NOTICE: CLEANSUBS >> SUBTITLES DOWNLOAD PATH SET TO: 'D:\_DOWNLOAD\'
14:05:00 T:11932  NOTICE: CLEANSUBS >> INITIALIZING OVERLAY
14:05:03 T:11932  NOTICE: CLEANSUBS >> CURRENT WINDOW 10153 - STARTING TIMER
14:05:03 T:11932  NOTICE: CLEANSUBS >> EXSUBS: False
14:05:03 T:11932  NOTICE: CLEANSUBS >> SUBTITLES DOWNLOAD PATH SET TO: 'D:\_DOWNLOAD\'
14:05:23 T:12208  NOTICE: CLEANSUBS >> SUBS ADDED >>XnCQN74dPcbtdBbh2qY8qsnlAMvAxXsl4_WWdZxz67eJuXbTq4Lmsi1LxBRPwdbsiiVmuw4mrw=m18.sr.srt
14:05:23 T:12208  NOTICE: CLEANSUBS >> SQL ERROR IN CheckDatabase
14:05:23 T:12208  NOTICE: CLEANSUBS >> SUB STATS WILL BE ADDED TO LOCAL DATABASE
14:05:23 T:12208  NOTICE: CLEANSUBS >> ENC >> TRYING ENCODING utf-8
14:05:23 T:12208  NOTICE: CLEANSUBS >> ENC >> TRYING ENCODING cp1250
14:05:23 T:12208  NOTICE: CLEANSUBS >> ENC >> TRYING ENCODING cp1251
14:05:23 T:12208  NOTICE: CLEANSUBS >> ENC >> TRYING ENCODING cp1252
14:05:23 T:12208  NOTICE: CLEANSUBS >> ENC >> TRYING ENCODING cp1253
14:05:23 T:12208  NOTICE: CLEANSUBS >> ENC >> TRYING ENCODING cp1254
14:05:23 T:12208  NOTICE: CLEANSUBS >> ENC >> TRYING ENCODING cp1255
14:05:23 T:12208  NOTICE: CLEANSUBS >> ENC >> OPENED WITH ENCODING: cp1256
14:05:23 T:12208  NOTICE: CLEANSUBS >> SQL ERROR IN AddtoDatabase : no such table: stats
14:05:23 T:12208  NOTICE: CLEANSUBS >> PROCESSED IN 0.08 SECONDS, REMOVED 6 LINES
14:05:23 T:12208  NOTICE: CLEANSUBS >> SUBS PROCESSED >>XnCQN74dPcbtdBbh2qY8qsnlAMvAxXsl4_WWdZxz67eJuXbTq4Lmsi1LxBRPwdbsiiVmuw4mrw=m18.sr.srt
14:05:23 T:11932  NOTICE: CLEANSUBS >> PLAYBACK >>RESUMED<<
14:05:23 T:11932  NOTICE: CLEANSUBS >> EXSUBS: False
14:05:23 T:11932  NOTICE: CLEANSUBS >> SUBTITLES DOWNLOAD PATH SET TO: 'D:\_DOWNLOAD\'
14:05:24 T:11932  NOTICE: CLEANSUBS >> STOPPING TIMER - NOT IN SUBS DIALOG ANYMORE
14:05:28 T:12208  NOTICE: CLEANSUBS >> PROVIDER LOGO FOUND: C:\Users\lanik\AppData\Roaming\Kodi\addons\service.subtitles.opensubtitles_by_opensubtitles\logo.png
14:06:56 T:11932  NOTICE: CLEANSUBS >> PLAYBACK >>PLAYING<<
14:06:56 T:11932  NOTICE: CLEANSUBS >> EXSUBS: False
14:06:57 T:11932  NOTICE: CLEANSUBS >> SUBTITLES DOWNLOAD PATH SET TO: 'D:\_DOWNLOAD\'
14:06:59 T:11932  NOTICE: CLEANSUBS >> CURRENT WINDOW 10153 - STARTING TIMER
14:06:59 T:11932  NOTICE: CLEANSUBS >> EXSUBS: False
14:06:59 T:11932  NOTICE: CLEANSUBS >> SUBTITLES DOWNLOAD PATH SET TO: 'D:\_DOWNLOAD\'
14:07:00 T:11932  NOTICE: CLEANSUBS >> LAST RUN 10 MINUTES AGO
14:07:03 T:9508  NOTICE: CLEANSUBS >> SUBS ADDED >>master.hr.srt
14:07:03 T:9508  NOTICE: CLEANSUBS >> SQL ERROR IN CheckDatabase
14:07:03 T:9508  NOTICE: CLEANSUBS >> SUB STATS WILL BE ADDED TO LOCAL DATABASE
14:07:03 T:9508  NOTICE: CLEANSUBS >> ENC >> TRYING ENCODING utf-8
14:07:03 T:9508  NOTICE: CLEANSUBS >> ENC >> OPENED WITH ENCODING: cp1250
14:07:03 T:9508  NOTICE: CLEANSUBS >> SQL ERROR IN AddtoDatabase : no such table: stats
14:07:03 T:11932  NOTICE: CLEANSUBS >> PLAYBACK >>RESUMED<<
14:07:03 T:11932  NOTICE: CLEANSUBS >> EXSUBS: False
14:07:03 T:11932  NOTICE: CLEANSUBS >> SUBTITLES DOWNLOAD PATH SET TO: 'D:\_DOWNLOAD\'
14:07:03 T:9508  NOTICE: CLEANSUBS >> PROCESSED IN 0.08 SECONDS, REMOVED 5 LINES
14:07:03 T:9508  NOTICE: CLEANSUBS >> SUBS PROCESSED >>master.hr.srt
14:07:03 T:11932  NOTICE: CLEANSUBS >> STOPPING TIMER - NOT IN SUBS DIALOG ANYMORE
14:07:08 T:9508  NOTICE: CLEANSUBS >> PROVIDER LOGO FOUND: C:\Users\lanik\AppData\Roaming\Kodi\addons\service.subtitles.opensubtitles_by_opensubtitles\logo.png
14:07:32 T:11932  NOTICE: CLEANSUBS >> EXIT

Can you post the log?
Reply
Call me ignorant Confused, but how do you get such a clean log with only notices? If I turn debug logging on, entries show as "debug" and not as "notice". If turn debug logging off, there's no appearance of CleanSubs at all.

Anyway when CleanSubs is set to off (not disabled) and I've manually enabled subs again, the "not showing subs problem" does not occur anymore. The moment I turn CleanSubs on and use it once, subs are shown for that video only, but are disabled for any other.

From your log, I gather you're streaming some web related content (like "XnCQN74dPcbtdBbh2qY8qsnlAMvAxXsl4_WWdZxz67eJuXbTq4Lmsi1LxBRPwdbsiiVmuw4mrt") this is perhaps not a library item. Mine are and that's probably the difference.

CleanSubs momentarily disables the downloaded sub, cleans it and enables it again (from what I gather from your post before), But perhaps it mistakenly also disables global subtitles showing which probably is a library thing.........but I'm just guessing here.
Reply
To get the "clean" log I use excellent freeware "Log viewer 2.1.1 by Kurt Hagen". It can display log in almost realtime and has excellent filtering and highlighting.

If you have Kodi v17 you have to enable debug logging. In v16 it is not needed.

Will try with local media.
Reply
Seems my previous reply got lost in the migration......Anyway, I'll try to summarize.

It seems that CS in NOT to blame for subtitles not showing and Kodi itself is the culprit. That's because it doesn't properly show embedded subtitles anymore, even though you told it to do so.

Lots of mkv's have embedded (sub-rip format) subtitles. Autosubs recognizes that and does NOT fire. Kodi does probably recognize it's presence but does NOT display the embedded subs. At least not initially, but only if you'll trigger a "ShowSubtitles" event.

This only happens for NEW content with embedded subs (library or not). After a new item has been played for xxx seconds, an entry will be written to the MyVideosxxx.db. This entry is written regardless if you use the video library and is used for resuming playback time and such. Once that particular episode is played again the "<showsubtitles>true</showsubtitles>"in "<defaultvideosettings>" will be obeyed and the subtitles are shown.

Somehow, according to related forum topics, the Kodi code has changed regarding embedded subtitles in relation to language track. If the subtitle is not bound to the preferred audio language track, it will not be displayed. No matter what your settings are. This was an issue in the v17 beta stages but has not been resolved yet.
Reply
@DragonFly,

That is a very strong possibility. We are using a backup of the original forum and the backup is a 16 hour old backup as the data centre took the original forum offline without notice. This means a number of posts were lost... maybe upto 60?? but we cant be sure.

Now we are relying on those members to notice their missing posts and re-post if they choose to.

Apologies for the inconvenience.
My Signature
Links to : Official:Forum rules (wiki) | Official:Forum rules/Banned add-ons (wiki) | Debug Log (wiki)
Links to : HOW-TO:Create Music Library (wiki) | HOW-TO:Create_Video_Library (wiki)  ||  Artwork (wiki) | Basic controls (wiki) | Import-export library (wiki) | Movie sets (wiki) | Movie universe (wiki) | NFO files (wiki) | Quick start guide (wiki)
Reply
(2017-10-07, 19:30)DragonFly Wrote: It seems that CS in NOT to blame for subtitles not showing and Kodi itself is the culprit. That's because it doesn't properly show embedded subtitles anymore, even though you told it to do so.

Lots of mkv's have embedded (sub-rip format) subtitles. Autosubs recognizes that and does NOT fire. Kodi does probably recognize it's presence but does NOT display the embedded subs. At least not initially, but only if you'll trigger a "ShowSubtitles" event.

This only happens for NEW content with embedded subs (library or not). After a new item has been played for xxx seconds, an entry will be written to the MyVideosxxx.db. This entry is written regardless if you use the video library and is used for resuming playback time and such. Once that particular episode is played again the "<showsubtitles>true</showsubtitles>"in "<defaultvideosettings>" will be obeyed and the subtitles are shown.

Somehow, according to related forum topics, the Kodi code has changed regarding embedded subtitles in relation to language track. If the subtitle is not bound to the preferred audio language track, it will not be displayed. No matter what your settings are. This was an issue in the v17 beta stages but has not been resolved yet.

I can't have access to embedded subs.... Smile
Reply
  • 1
  • 17
  • 18
  • 19(current)
  • 20
  • 21
  • 24

Logout Mark Read Team Forum Stats Members Help
CleanSubs - (Clean subtitles from the ads and other rubbish)2