[mo123]

https://developer.android.com/reference/...G_IEC61937 <- it is 13 (d), but we call

Code:

GetStaticValue(c, CJNIAudioFormat::ENCODING_IEC61937, "ENCODING_IEC61937");

So that gets overwritten with the value you actually used yourself. But it's better to use 13 - as this is how it is defined in the API - for compatibility arround _all_ mediaplayers.

Kodi 16.1 logs where IEC 61937 pass-through worked.
https://drive.google.com/file/d/0B2JoqOT...JxRjA/view

Spreadsheet with Kodi Test Videos with Kodi 16.1 IEC pass-through based on RKMC.
https://drive.google.com/file/d/0B2JoqOT...FkUWM/view

^^ does not matter at all. We don't talk about "what works" but about how to do it properly to make it work once and for all in the way the API wants it.


The patch is fine (besides the 13 (d in hex)). Please also backport the int16 API - which is very easy to do.

For your code, add:

Code:

static jint android_media_AudioTrack_write_short(JNIEnv *env,  jobject thiz,
                                                  jshortArray javaAudioData,
                                                  jint offsetInShorts, jint sizeInShorts,
                                                  jint javaAudioFormat,
                                                  jboolean isWriteBlocking) {

    sp<AudioTrack> lpTrack = getAudioTrack(env, thiz);
    if (lpTrack == NULL) {
        jniThrowException(env, "java/lang/IllegalStateException",
            "Unable to retrieve AudioTrack pointer for write()");
        return 0;
    }

    jshort* cAudioData = NULL;
    if (javaAudioData) {
        cAudioData = (jshort *)env->GetShortArrayElements(javaAudioData, NULL);
        if (cAudioData == NULL) {
            ALOGE("Error retrieving source of audio data to play, can't play");
            return 0; // out of memory or no data to load
        }
    } else {
        ALOGE("NULL java array of audio data to play, can't play");
        return 0;
    }
    jint written = writeToTrack(lpTrack, javaAudioFormat, (jbyte *)cAudioData,
                                offsetInShorts * sizeof(short), sizeInShorts * sizeof(short),
                                isWriteBlocking == JNI_TRUE /* blocking */);
    env->ReleaseShortArrayElements(javaAudioData, cAudioData, 0);

    if (written > 0) {
        written /= sizeof(short);
    }

    return written;
}

Don't forget to add the method definition to the proper file.

I see in line 669, android_media_AudioTrack.cpp file I posted(in the above first attachment, I double zipped the file?) your code was implemented, only difference I found was this from my code to yours.

line 672 - jint javaAudioFormat) { to
jint javaAudioFormat,
jboolean isWriteBlocking) {
&
line 695 - true /*blocking write, legacy behavior*/); to
isWriteBlocking == JNI_TRUE /* blocking */);

Is that all that is needed to be changed or am I missing something?

I will try to build some new firmware with the changes.

Thanks