2016-10-04, 20:15
You are right, I was not involved at all in the ratings debate, nor the implementation. I was new at the time, and moreover I don't use ratings myself so really wasn't paying attention either. AFAIK the work has been done. But I am now the guy that tries to take care of the music library features and functions, and if there are unresolved issues I guess I'll be the one to try to fix it.
1) Both rating and my rating should be 0 to 10, for both albums and songs. That is the intention anyway. Because album rating was 0 - 5 when upgrading from an earlier database version any existing values (in old db) are doubled. There was also a bug in loading from NFO that was trucating values, but is fixed in the nightly you are using. Something in all that is resulting in what you see, but I would not like to be sure exactly what!
2) Numbers not stars is a skins thing. Ask your friendly skinner for what you would like the display to be.
3) Conversion of NFO rating to my rating is going to be a big user issue. I think one of the ratings PRs commented on it being necessary, but nothing was offered as assistence. [Notes: not all devs are as kind an caring as I am ]. Honestly some kind of bulk editing of user NFO files is a better conversion approach than have Kodi variably import/export xml tags to different database fields. I am not saying users should edit NFO one at a time, that would be horrible.
4) Sorry suppression is not easily, otherwise I would have made all kinds rating invisible as personally it is all clutter!
Come back on 1) if I have been too flippent. Sorry but ratings, and the thought of time spent tidying up someone elses "bright idea" when I have lots of my own ideas I want to work on, don't bring out the best in me. But I will try.
1) Both rating and my rating should be 0 to 10, for both albums and songs. That is the intention anyway. Because album rating was 0 - 5 when upgrading from an earlier database version any existing values (in old db) are doubled. There was also a bug in loading from NFO that was trucating values, but is fixed in the nightly you are using. Something in all that is resulting in what you see, but I would not like to be sure exactly what!
2) Numbers not stars is a skins thing. Ask your friendly skinner for what you would like the display to be.
3) Conversion of NFO rating to my rating is going to be a big user issue. I think one of the ratings PRs commented on it being necessary, but nothing was offered as assistence. [Notes: not all devs are as kind an caring as I am ]. Honestly some kind of bulk editing of user NFO files is a better conversion approach than have Kodi variably import/export xml tags to different database fields. I am not saying users should edit NFO one at a time, that would be horrible.
4) Sorry suppression is not easily, otherwise I would have made all kinds rating invisible as personally it is all clutter!
Come back on 1) if I have been too flippent. Sorry but ratings, and the thought of time spent tidying up someone elses "bright idea" when I have lots of my own ideas I want to work on, don't bring out the best in me. But I will try.