(2016-11-04, 19:03)WelshPaul Wrote: As an aside Dave, I wonder whether Music Corner has created something of a rod for your back and a circular reference for us, if you are the only Team-Kodi person who bothers to look at these issues. While I appreciate you try to answer everyone's questions, it is a little fruitless if as you say you didn't instigate the change and don't even use it. Shouldn't those who did try to address these issues.
I had a good chuckle at that one Paul, "should" does not come into how the Kodi team works. Banish that kind of thinking, it leads nowhere.
Talking to me isn't friutless, I can, have, and will continue to try to fix things. I love music corner, rather than the forum splatter we have before. But the rest of you need to know I'm pretty much all you have got at the moment for music library specific things. I'm one guy with limited time and my own interests, a volumnteer doing it for free because I find it interesting etc. I don't want a medal or praise etc., but patience, good humour and general helpfulness is always nice.
Back to the POPM issue... and seeking to understand. If I get the issue then I can fix it.
The notes I have says that MediaMonkey encodes ratings as follows
0.5=26, 1=51, 1.5=76, 2=102, 2.5=128, 3=153, 3.5=178, 4=204, 4.5=230, 5=255
Does this seem to be correct? Have you found something from media Monkey I can reference?
For comparison Windows Media Player 9 Series uses 1 = 1, 2 = 64, 3=128, 4=196 (not 192), 5=255, and I guess we need to cover that too.
Since at least Frodo Kodi converted POPM like this
Code:
if (popm == 0) return '0';
if (popm < 0x40) return '1';
if (popm < 0x80) return '2';
if (popm < 0xc0) return '3';
if (popm < 0xff) return '4';
return '5';
loosing any half values MediaMonkey may have included.
MM 0.5=26 was Kodi 1 in v17 is 2
MM 1=51 was Kodi 1 in v17 is 3
MM 1.5=76 was Kodi 2 in v17 is 4
MM 2=102 was Kodi 2 in v17 is 5
MM 2.5=128 was Kodi 3 in v17 is 6
MM 3=153 was Kodi 3 in v17 is 7
MM 3.5=178 was Kodi 3 in v17 is 8
MM 4=204 was Kodi 4 in v17 is 9
MM 4.5=230 was Kodi 4 in v17 is 10
MM 5=255 was Kodi 5 in v17 is 10
OK, so whereas Kodi was fudging the values one way, effectively rounding 0.5, 1.5, 2.5 and 3.5 up but 4.5 down, it is now fudging and producing a bias towards 10. That doesn't seem right (assuming the Media Monkey scheme is definative). Looks like a mistake to me in the way the new out of 10 stuff was implemented.
How definative is the Media Monkey rating scheme? Remember I don't rate stuff, I have no idea on scope.