[agb2]

I renamed the custom samba.conf and all works!

The custom parts were there because I wanted to change the workgroup name and 'master browser' settings.
Presumably what I need to do is copy /run/samba/smb.conf to .config and edit it there?
I guess this is what "rebase on /etc/samba/smb.conf" means.
This is on #323 by the way.
Thanks for the help :-}

Edit.
Yep, did that, changed workgroup name and master browser settings, working fine.

Thanks for the update.

With #0323 there's a fix so that the previously static (and potentially stale) *.conf.sample files in /storage/.config now update to latest sample files shipped with the system, so you should be able to copy /storage/.config/samba.conf.sample to /storage/.config/samba.conf and then edit the latter.

Using /run/samba/smb.conf isn't actually a good idea as that is an automatically generated file based on your config file (either /etc/samba/smb.conf, or /storage/.config/samba.conf). Several modifications are made, including the addition of automounted shares, and enabling passwords (if configured).

OK, I'll have a look at the sample, and so as you suggest. Thanks for the info.