[Milhouse]

Again I may be mistaken.

Thanks, I think you're probably right - I've changed "84" to "0" in the PR.

This is the conf check as it appears in bin/config.log, before:

Code:

[2/2] Linking default/testprog
['/home/neil/projects/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.0-devel/toolchain/bin/x86_64-libreelec-linux-gnu-gcc', 'default/test_1.o', '-o', '/home/neil/projects/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.0-devel/samba-4.7.0/bin/.conf_check_0/testbuild/default/testprog', '-march=x86-64', '-m64', '-Wl,--as-needed', '-fuse-linker-plugin', '-flto', '-lreadline', '-lpthread', '-Wl,-no-undefined']
84

returncode 0
ok

and after:

Code:

[2/2] Linking default/testprog
['/home/neil/projects/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.0-devel/toolchain/bin/x86_64-libreelec-linux-gnu-gcc', 'default/test_1.o', '-o', '/home/neil/projects/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.0-devel/samba-4.7.0/bin/.conf_check_0/testbuild/default/testprog', '-march=x86-64', '-m64', '-Wl,--as-needed', '-fuse-linker-plugin', '-flto', '-lreadline', '-lpthread', '-Wl,-no-undefined']
0

returncode 0
ok

I guess it doesn't make a significant difference, as the define for HAVE_ICONV_ERRNO_ILLEGAL_MULTIBYTE is the same before/after (presumably it only matters if the returncode is -1).