[User 384674]

Simply adding a comment in the wrong place in an xml file, even if the comment is empty, causes a parsing error and, as a result, the window is not rendered correctly. Now before going any further, if comments are not supported in skin xml files, then that's fine. However, if they are supposed to be supported, then continue...

In Estuary using the Wall view, the following screen shows how a video that doesn't have a poster image, and is in focus, should be displayed (note the blue highlight around FDR One Man Show):


I now inserted an empty comment at line 236 to the base Estuary file View_54_InfoWall.xml:


The result is that the the following error is in the log:

14:05:51.153 T:5320   DEBUG: ------ Window Init (Home.xml) ------
14:05:51.153 T:5320    INFO: Loading skin file: Home.xml, load type: KEEP_IN_MEMORY
14:05:51.166 T:5320   ERROR: Misplaced [
14:05:51.166 T:5320   ERROR: Error parsing boolean expression $param[focused]

AND the blue highlight no longer displays:

[sualfred]

The bug is quiet old and exists since the integration of the params.
Some params work with dozens of <!-- blabla --> and sometimes 2 are enough to break everything. Completely random.

[User 384674]

Thanks for the background info, sualfred.

However, my opinion is that the ability to freely put comments in code is important. I see even base Estuary has comments in some xml files-- given this bug, any one of those comments could have damaged the behavior of the file. I have provided a case that is repeatable. Could someone look at it?

[sualfred]

I got used to it in the last 2< years ^^

https://trac.kodi.tv/ is the way to go.

[User 384674]

Advice taken and done. Thanks.
https://trac.kodi.tv/ticket/18060