2020-04-18, 10:13
First of all, great work, @im85288! I've integrated the addon into the OSMC skin now as well.
Two issues I've discovered though:
- The maximum amount that can be set for the notification to show up before the end of an episode's playback seems to be 120 seconds. Could that be increased? I've got a lot of episodes with credits longer than 3 minutes. Maybe give users the option to set a maximum period of 5 minutes to cover all possible cases?
- The second counter is coloured pink at the moment without a convenient way to change this. Could this be made adjustable for skinners without having to edit the addon's strings.po file on the user side? For our skin the colour doesn't really fit and it's hard to read it in many scenarios - I've chosen not to show the counter currently.
Cheers!
Two issues I've discovered though:
- The maximum amount that can be set for the notification to show up before the end of an episode's playback seems to be 120 seconds. Could that be increased? I've got a lot of episodes with credits longer than 3 minutes. Maybe give users the option to set a maximum period of 5 minutes to cover all possible cases?
- The second counter is coloured pink at the moment without a convenient way to change this. Could this be made adjustable for skinners without having to edit the addon's strings.po file on the user side? For our skin the colour doesn't really fit and it's hard to read it in many scenarios - I've chosen not to show the counter currently.
Cheers!