2021-09-12, 17:13
I also found a few things to improve in the flag scraping algorithms in Includes.xml :
I am using TinyMediaManager. It allows to put a "." inbetween all flags (HDR, DTS, ATMOS, etc...), but the current logic misses a few things :
1) TMM makes a distinction between "EAC3 ATMOS" and "TrueHD ATMOS, so it would be nice if the skin did this too. At the very least, we cannot just assume all atmos flags will be preceded with a dot. So, I changed the xml a bit to :
<expression name="IsAudioCodecATMOS">
String.Contains(ListItem.FileNameAndPath,atmos.) | String.Contains(ListItem.FileNameAndPath,atmos-)
| [VideoPlayer.IsFullscreen + [String.Contains(Player.FileNameAndPath,atmos.) | String.Contains(Player.FileNameAndPath,atmos-)]]
</expression>
2) HDR10+ is a bit trickier. TMM exports them as "HDR10+" while we assume here it is "HDR10Plus"
Replacing them with "HDR10+" in the xml does not work as the + sign is not recognized inside a string. Maybe there is a workaround ?
It would be nice if TMM could configure the output labels, but apperently it doesn't, so I am looking now at the skin side.
I am using TinyMediaManager. It allows to put a "." inbetween all flags (HDR, DTS, ATMOS, etc...), but the current logic misses a few things :
1) TMM makes a distinction between "EAC3 ATMOS" and "TrueHD ATMOS, so it would be nice if the skin did this too. At the very least, we cannot just assume all atmos flags will be preceded with a dot. So, I changed the xml a bit to :
<expression name="IsAudioCodecATMOS">
String.Contains(ListItem.FileNameAndPath,atmos.) | String.Contains(ListItem.FileNameAndPath,atmos-)
| [VideoPlayer.IsFullscreen + [String.Contains(Player.FileNameAndPath,atmos.) | String.Contains(Player.FileNameAndPath,atmos-)]]
</expression>
2) HDR10+ is a bit trickier. TMM exports them as "HDR10+" while we assume here it is "HDR10Plus"
Replacing them with "HDR10+" in the xml does not work as the + sign is not recognized inside a string. Maybe there is a workaround ?
It would be nice if TMM could configure the output labels, but apperently it doesn't, so I am looking now at the skin side.