2022-01-12, 17:40
(2022-01-12, 17:33)beatmasterrs Wrote:(2022-01-12, 15:21)HoleyBoley Wrote:(2022-01-12, 15:10)beatmasterrs Wrote: Thanks for your effort. Of course, PR' can be submitted, I welcome that. But it would be helpful if the changes were sufficiently tested before E.g: if you choose the light theme, the background/fanart is dark instead of light. So a black bg.jpg isn't the right way, as there were light colored areas in the top/bottom left before.
I wrote that down about the bg.jpg in the commits and descriptions on Github. The new PNGs are likely suitable for the Light theme, but the new bg JPG is likely only suitable for the Dark theme. Did I not write it down in the right place? Apologies if so.
I'm not sure it's possible to have a bg.jpg that works for both Dark and Light themes (which is why I didn't bother testing it with Light). I suppose it isn't workable to dynamically use either version depending on the chosen settings (EDIT: e.g. have both Light and Dark versions of the JPG (or even the PNGs too) in the textures.xbt)?
EDIT2: ah I see now that I've suggested the changes directly to the master. I instead meant to suggest a separate branch(?) so we could discuss and test possible solutions. As said, I'm very new to Github. Apologies for any confusion.
I will create a new branch for testing, when I'm home
Awesome!
I don't fully grasp the code, but looking at some recent commits you did, it seems you've already explored possibilities for use of a variable floor.png and bg.jpg. Maybe this could tie into that nicely.