2023-03-16, 19:53
(2023-03-16, 12:31)robertlaing Wrote: Just noticed that in the media flag options in the settings you can select rating or not.
If you select the rating it appears in the left hand corner after the HD SD icon.
If you don't select the rating, then the rating is not shown in the left hand corner. As shown in my photos in my 3 posts above.
However the rating is always shown after the HD SD icon on movie and tv shows info and always in the song info screen.
Surely the code on the info pages should be checking to see if the rating has been selected or not?
You do the same for the other media flags, check if they have been selected before displaying, eg subtitles etc. so the same should be done for the ratings.
Rating not selected and it is not shown in the media flag section:
https://imgur.com/a/62rSXO8
Rating not selected but it shows in the media flag section, should be an "if" statement to decide whether to show the rating or not based on the settings:
https://imgur.com/a/PqyfG8G
Checks are made for parental rating, IMDB Top 250, subtitles etc to determine whether they are shown or not.
But the check for the rating is missing on the info pages.
Can you please kindly amend the code so that on the TV Show Info, Movie Info and Song Info pages, only the media flags selected are shown.
In my example it is clear that the check to whether to show the rating or not on the info pages is missing.
Many thanks.
A few words about the behavior in the settings related to media flags: This was done intentionally by @fabricionaweb or/and @Nanomani (I do not know exactly anymore) so that you can switch on and off individual flags in the lower area by option, but in the video/music info all flags are displayed and I am totally fine with it
Also, there will be no changes from me for any differences from the library to the OSD, as I am happy with the way things are and they don't bother me. If someone wants to submit a PR for this, feel free