[ashlar]

I have found a way to play the second version (or the third or fourth, etc., I suppose).

If one selects Info on a movie with multiple versions, there's a button on the bottom left in the Info window. There you can browse the versions, with the same window that appears when you press Play on a movie. This time there's other options available (but renaming versions is not one of them) and if you select a version, that's the version that you get to play if you press the Play button in that window.

[XODIDOX]

Hi @DarrenHill / @Karellen, I'm not sure where this thread should be moved to, but basically, I want more people to try this and give feedback. Especially for the system defined versions, I'm trying my best to collect these versions, but there may be some missing or the name need to be changed. Want to get more opinions for this.

@ashlar, thank you very much for the feedback, it's very useful. The first thing you mentioned is definitely a bug, I'll look into this. Currently in the progress to change the coding style for review, don't have a working build yet.

For the ways to change the version name, there are in fact a few of them.

1. The way in the first posts of this threat still apply to this new design. You can use the context menu "Manage movie version" for the movie item in library to change the version. Just choose the SAME movie as destination, and you will get the chance to give a new name for the version. But this only works for the movie with one version. Otherwise, you need to remove the movie from library and scan it again to apply above method.
   
2. Another way is in the new "Versions" dialog you've found in movie info dialog. Just set another version as default version and then select the version you want to rename and remove that version with the "Remove Version" button. Then you can use the "Add Version" button to choose the file again to add a new version, and you'll be able to choose a new version.
   

The reason for no "Rename Version" button is because there are too many buttons in the dialog, no space for one more button. And the "Add Version"/"Remove Version" can be used in this way, so I didn't add this button.

For the "Version" dialog got cancelled but play continued, this is by design. The consideration for this is, user already chose paly a movie, that's their intention. So no matter what they've chosen in the "Version" dialog, Kodi should play one, just like there is no this "Version" dialog. If user choose a different version than default, Kodi play that version, otherwise, just play the default version.

[ashlar]

For the "Version" dialog got cancelled but play continued, this is by design. The consideration for this is, user already chose paly a movie, that's their intention. So no matter what they've chosen in the "Version" dialog, Kodi should play one, just like there is no this "Version" dialog. If user choose a different version than default, Kodi play that version, otherwise, just play the default version.

Read everything else and I will experiment with renaming. Not having tried yet, just by reading your description, I fear this might be too convoluted. So maybe there could be a way to have a Rename button somewhere in the interface. But before getting back on this I need to experiment a little. Maybe doing is easier than reading.

On the above, though, I am pretty sure it sort of violates one core tenet of the overall Kodi interface. As long as you're still in a menu, there is a way to go back. The default value, when set, makes you play a specific version of a movie (which you beforehand set as default, right?). If the user hasn't selected a specific default, I wouldn't assume anything.

At the end of the day, this "nesting" of movies is similar to Movie Sets. When I enter a Movie Set I can exit it and I expect to be able to do it when I enter Movie Versions.

I don't know if it comes from the programming side of it, but the overall idea of a "default/base/standard" version needing to exist once a user has created a Movie Versions group... what practical results does it provide? It seems to be generating more headaches for you than anything. :-)

The above is obviously just the way I see it. I'm sure others will chime in and maybe my view will not be that of the majority. :-)
But if I'm right about the "core tenet of the interface", then maybe it'll need to change.

Keep up the good work. This is looking incredibly promising. Thank you!

[XODIDOX]

There is always a default version for a movie, all other versions you added to that movie will be alternative versions. And in the "Versions" dialog, you can set another version as default. But there is always a default version.

I agree with you a bit for the not able to cancel playing if you didn't choose "Play" in the "Version" dialog. I'll think about this design.

With my upcoming update to eliminate the "Version" dialog for movie with only one version, I think that it will eliminate your headache. But the dialog needs exist for any movie because it provides way for you to add new version and video extras.

[Karellen]

I'm not sure where this thread should be moved to, but basically, I want more people to try this and give feedback

Hi XODIDOX.
I have added a banner to the forum to draw attention to this thread. Is that ok?

[jjd-uk]

Test Builds - updated 28/10/23

Windows 64 https://mirrors.kodi.tv/test-builds/wind...on-x64.exe
Windows 32 https://mirrors.kodi.tv/test-builds/wind...on-x86.exe
OS-X x64 https://mirrors.kodi.tv/test-builds/osx/...-arm64.dmg
OS-X ARM https://mirrors.kodi.tv/test-builds/osx/...x86_64.dmg
Android ARM64 https://mirrors.kodi.tv/test-builds/andr...64-v8a.apk
Android ARM https://mirrors.kodi.tv/test-builds/andr...bi-v7a.apk

@XODIDOX add these to your first post introduction if you want so they don't become buried.

[black_eagle]

Some feedback from a quick test.

• Not keen on interrupting the scan, many users scan headless or with monitors etc turned off.
  
• One of the two added tables just contains the strings defined in strings.po.  Pretty sure they could just be added to an existing table in a new field (where needed) - Are they even needed at all ?  User defined
  
• Same with the video versions.  I understand it links to the various files that make up the different movie versions but it could probably be handled by extending the sets table ?
  
• Not 100% sure that extras should be added here - I know its a thing often requested but it's not the same as extended cuts, directors cuts etc - Maybe keep these separate ?
  

 Just going over the PR and looking at the code, there is a request to drop the incomplete json stuff which still needs dropping.  I can help with that in a later PR though

To be clear, I think this a much wanted and worthwhile addition.  I just personally think it needs a bit more work.

[XODIDOX]

Thanks @Karellen. That should work. I'll let you know when to do that after I updated the first posts for the latest changes.
Thanks @jjd-uk for these builds. I'm working on the fix from the review feedback and problems reported/found. Need new builds after I updated the PR.

Thanks @black_eagle for the feedback. Let me explain each of them:

1. There is a new option in settings to hide this prompt during scanning. It's off by default, thus the prompt. The main reason is I believe it's a small number of different versions, so the prompt times is manageable.
   
2. A dedicated table is used for multiple purposes; user defined versions are saved there. it's also used by for switching to different language automatically after user switched UI language. A separate table make this clear enough.
   
3. sets table is for movies, but this version feature can work with movie/tv shows/music videos, etc. It should be in a separate place.
   
4. The new version dialog shows the versions and extras in separate lists. It's clear enough.
   
5. I'll drop the JSON part. And do a separate PR later with your help.
   

[black_eagle]

@XODIDOX, thanks for your reply.  I guess a lot of that makes sense and I will do some more testing to see how it pans out.  In the meantime, you might want to also remove the 'reload skin' and 'toggle skin debug' from the power menu, as neither of them should be available to standard users.

Cheers and keep up the good work!

[XODIDOX]

@black_eagle thanks for the reminder, I'm keep them until the PR is accepted and ready to be merged. I expect the UI still needs to be improved, and these helped me a lot for this part.

[Hitcher]

In the meantime, you might want to also remove the 'reload skin' and 'toggle skin debug' from the power menu, as neither of them should be available to standard users.

Along with the debug labels and grid.

[ashlar]

Test Builds

Windows 64 https://mirrors.kodi.tv/test-builds/wind...on-x64.exe
Windows 32 https://mirrors.kodi.tv/test-builds/wind...on-x86.exe
OS-X x64 https://mirrors.kodi.tv/test-builds/osx/...x86_64.dmg
OS-X ARM https://mirrors.kodi.tv/test-builds/osx/...-arm64.dmg
Android ARM64 https://mirrors.kodi.tv/test-builds/andr...64-v8a.apk
Android ARM https://mirrors.kodi.tv/test-builds/andr...bi-v7a.apk

@XODIDOX add these to your first post introduction if you want so they don't become buried.

This is the same as the previous version? Judging by the filename I would think so but I do not want to assume.

Edit: yes, it's the same version. Now I understand the last number refers to movieversion branch.

[XODIDOX]

Hi @jjd-uk, I just pushed the latest update. Can you make the test builds for it? Thanks!

[jjd-uk]

New builds have been kicked off

[black_eagle]

Just a couple of screen shots to show @XODIDOX what I mean about the SQL

Current query gives this -

New query gives this -

There is a diff here that will fix up the navigation. You need to create an xml file in system/library/video/movies with the content here which will be copied into the right place when you build Kodi (userdata/library/video/movies/). That xml file needs adding to your PR.