[mikeSiLVO]

As it happens we've been discussing this on the Teams internal Slack channel.

Both myself and Hitcher agree that from a design POV that the long term aim should be to use Dialog Select for selecting a playback item, and the new Dialog Video Version be used only for management.

For consistancy perhaps something similar to the Blu-Ray simple menu could be done



I'm not a C++ coder but I can sometimes follow what a code section is doing, even I don't understand the details of the specific code used, and this would suggest to me that this uses Dialog Select https://github.com/xbmc/xbmc/blob/master...u.cpp#L108

You could have something similar for Versions where the Versions are displayed (like those Main Titles on a Bluray are shown) then have a Show Extras at the bottom which would another Dialog Select showing just the Extras. Having a Extras in their own Dialog Select would also allow a Extras button to be added to Dialog Video Info.

Simple menu like that is great just not sure if icons are better than a poster or thumb image. DialogSelect has list id="6" visible for when an image is available. I agree and think removing the videoversionplay window and using select dialog is the best way to go. We are just selecting something after all. DialogVideoVersion.xml for version and extras management makes sense to me instead of the one for both management and play

As I put in my post, the dialog should report to the skin engine that the item is selected and then we can adjust the colour on the skin side using the skin colour definition for selected. So something is missing from the core C++ side as changing the colour definition for selected in the skin currently has no effect on dialogvideoversion.

Also agree, this does not currently work and would be great if it did!

@mikeSiLVO As I'm not a skinner, I don't have much knowledge for skinning design except adding the VideoVersion dialog to Estuary. I can't see what's the pain for you in skin designing for this dialog. But please list all issues in detail (better with screenshots), instead of a generic description, I don't even know how I can check the issue you mentioned

The original idea was just using a single VideoVersion dialog, both management and playing use it. A new dialog is needed for management, and it can also show additional information (artwork, path, etc.) instead of just a plain list. There is a screenshot for this in OP of this thread.

With the feedback for a dedicated dialog for playing, thus the current design, but underlying both management and playing are using the same dialog and only a single variable to control this. I'm not sure if/how about redesigning the playing dialog as the current design already shifted quite a bit from my original idea.

Please do keep in mind each one has their own idea for UI design. It's not possible to make everyone happy for a UI design. I wish Kodi team members can discuss this and make a final decision. The implementation part should be the easiest thing I can see.

For the additional infoLabels, I think people working on this feature in Kodi team are busy and don't even have time for the review for my pending PRs. I can work on these later when my current PRs merged, or someone else can work on this, it's not hard. Please do give a description of the purpose for each infoLabel you want.

Not sure how anyone else does skinning but I experiment using whatever is available in the Wikis and Doxygen to get my desired result. The pain I was mentioning is from a few different aspects, for example, the image for the movie selected is not saved anywhere so I currently use window properties and variables to achieve what already happens in DialogSelect. Focus should select the item and store the appropriate image.

As for the INFO labels, I mentioned previously that I cannot get IsVideoExtras to be true. I think it would be more beneficial to have a HasVideoExtras bool instead of HasVideoVersions be true for both. Separating the Extras and Versions just a smidge more makes things easier IMHO. There are ways to do the same by using Integer.IsGreater(Container(51).NumItems,0) or other skinamagics but it just seems simpler to have those bools be true/false and use conditions based on them. No harm in having the ListItem for video extras be true as well as that likely opens up more flexibility but as mentioned, it is never true for me no matter what I have tried.

A new dialog for management does make sense but not for selecting a version to play. I think that can be eliminated entirely for DialogSelect as I see no benefit in having any special handling for a list of choices with an image.

Thanks