[popy]

Thanks for your answer.

My tests are from 18.9 because i have other issues with 19.1 on my ATV's which prevent's me from migrating.
But, i have tested 19.1 a few weeks ago and the same issue occured, so matrix is not fixing this.

The "wait for network option" is no solution i think. Think of the scenario that the internet connection of the user is down (ex.: during storms),
and he can't watch local media from NAS...

So the only real solution is to fix the issue.

I dont know much about the code, but i think the following is happening (please correct me if i am wrong):

• PVR clients are offline and deleting the channels from the tv.db
  
• When they online again they are adding the channels again (with different unique id's), and there get's something messed up in the map
  

My understanding of how it should be:

• every channel has an unique channel id (ex.: hash of {pvr addon name + channel id})
  
• mapping is done with this unique id's
  
• when an pvr addon is offline, remove the channels from the channels table but not from the map
  
• when the addon is online again, readd the channels to the channels table with their unique id'
  

Can you bring some light into this how this currently works?

thx

[ksooo]

@phunkyfish in case of network down the add-on should return PVR_ERROR_foo on any call. If it for example does not on GetChannels the result will be that PVR cpre deletes all locally cached channel entries, because the add-on returned no channels with status PVR_ERROR_NO_ERROR. Could you please check the add-on implementation?

@popy the "autodelete : true" you found in the log has nothing to do with deleting any PVR data.

[popy]

@ksooo thanks for the hint, that sounds reasonable.
Is this also the case for kodi 18.9?

I have also created an github issue for pvr.zattoo (because i am using this also), see here: https://github.com/rbuehlma/pvr.zattoo/issues/125
And in the pvr.zattoo support forum from kodinerds: https://www.kodinerds.net/index.php/Thre...post654310

pOpY

[ksooo]

@ksooo thanks for the hint, that sounds reasonable.
Is this also the case for kodi 18.9?

I have also created an github issue for pvr.zattoo (because i am using this also), see here: https://github.com/rbuehlma/pvr.zattoo/issues/125
And in the pvr.zattoo support forum from kodinerds: https://www.kodinerds.net/index.php/Thre...post654310

pOpY

Yes, this is for 18 and 19.

[phunkyfish]

@phunkyfish in case of network down the add-on should return PVR_ERROR_foo on any call. If it for example does not on GetChannels the result will be that PVR cpre deletes all locally cached channel entries, because the add-on returned no channels with status PVR_ERROR_NO_ERROR. Could you please check the add-on implementation?

@popy the "autodelete : true" you found in the log has nothing to do with deleting any PVR data.

Ah, ok. That makes sense. I will check if there is any testing of the network but I believe it would just return an empty set hence it deletes.

So I guess @popy that your M3U file is located on a remote location? I.e. not a local file path.

Please try the following testbuilds for IPTV Simple on Matrix and see if it works: https://jenkins.kodi.tv/blue/organizatio.../artifacts

[popy]

@phunkyfish 
Thanks a lot for fixing the issue.
Sadly, i currently have no Android 19.1 setup which is not heavily in use by family members, all my ATV's are on 18.9, because of other issues in 19.1 (at least on my ATV's).
I have to solve those, before i can switch to 19.1.

But, i have an Windows 19.1 installation (for test purposes).
On this machine, i will try to reproduce the issue with the current release build and then, if it is solved, with your test build.

Another question:
I know, from a developer standpoint, you dont want to hear that question (i am a dev too) 
Your standard answer to the following question would be: just take the new version,
but i will ask it anyway 

If that issue is solved with your testbuild, is it possible todo an backport and build for kodi 18.9?

Thanks a lot
pOpY

[ksooo]

@phunkyfish 
Thanks a lot for fixing the issue.
Sadly, i currently have no Android 19.1 setup which is not heavily in use by family members, all my ATV's are on 18.9, because of other issues in 19.1 (at least on my ATV's).
I have to solve those, before i can switch to 19.1.

But, i have an Windows 19.1 installation (for test purposes).
On this machine, i will try to reproduce the issue with the current release build and then, if it is solved, with your test build.

Another question:
I know, from a developer standpoint, you dont want to hear that question (i am a dev too) 
Your standard answer to the following question would be: just take the new version,
but i will ask it anyway 

If that issue is solved with your testbuild, is it possible todo an backport and build for kodi 18.9?

Thanks a lot
pOpY

You better should report the issues you have with 18.9, open issues over at GitHub, so the devs have the chance to fix 19 instead of still having to deal with 18. Help us to move things forward. We don't have the power to maintain EOL Kodi versions.

[phunkyfish]

@popy windows is perfect. Any platform really to test if it works. You might want to disable zattoo for the test in case it suffers from the same issue (I don’t know but I hadn’t checked either).

Regarding your other kodi issues it’s possible some of your issues are fixed in the upcoming 19.2. Please test against master (we apply fixes there first) to see what is or is not still working today.

[popy]

@ksooo & @phunkyfish will move to kodi 19.1 as soon as i find time and hope to get the kodi project forward.

@phunkyfish 
I tried the following with the current release version 7.6.9:

• disabled all PVR addons, except IPTV Simple (released client 7.6.9)
  
• manually made groups with channels
  
• restarted kodi, just to be sure they stick when i am online -> they did
  
• exit kodi
  
• disabled network interface and started kodi
  
• channel sorting and groups are gone because of false return value in current release version
  

So i am able to reproduce the issue on windows!
Then i tried the following with your windows testbuild version 7.6.10:

• update addon to 7.6.10
  
• exit kodi
  
• restored a backup of the db
  
• restarted kodi, just to be sure they stick when i am online -> ALL CHANNELS are gon and groups are empty !?
  
• Checked if i am online -> i am online
  
• In the log the addon fetches the m3u (so proove kodi can access my NAS share)
  
• The addon returns always "server error"!? Can you please check that on your side and in the code?
  

Here is the full debug log with test build: https://paste.kodi.tv/aninibokig.kodi
So i was unable to check if kodi is offline because it also don't work online.

thx

[phunkyfish]

@ksooo & @phunkyfish will move to kodi 19.1 as soon as i find time and hope to get the kodi project forward.

@phunkyfish 
I tried the following with the current release version 7.6.9:

• disabled all PVR addons, except IPTV Simple (released client 7.6.9)
  
• manually made groups with channels
  
• restarted kodi, just to be sure they stick when i am online -> they did
  
• exit kodi
  
• disabled network interface and started kodi
  
• channel sorting and groups are gone because of false return value in current release version
  

So i am able to reproduce the issue on windows!
Then i tried the following with your windows testbuild version 7.6.10:

• update addon to 7.6.10
  
• exit kodi
  
• restored a backup of the db
  
• restarted kodi, just to be sure they stick when i am online -> ALL CHANNELS are gon and groups are empty !?
  
• Checked if i am online -> i am online
  
• In the log the addon fetches the m3u (so proove kodi can access my NAS share)
  
• The addon returns always "server error"!? Can you please check that on your side and in the code?
  

Here is the full debug log with test build: https://paste.kodi.tv/aninibokig.kodi
So i was unable to check if kodi is offline because it also don't work online.

thx

It’s entirely possible I have some logic wrong here. Let me take another look. I’m away currently so coding blind without being able to test!

[popy]

No problem, take your time.
I am here to test [emoji6]

[phunkyfish]

No problem, take your time.
I am here to test [emoji6]

Silly logic error, try these now and should be ok: https://jenkins.kodi.tv/blue/organizatio.../artifacts

[popy]

No problem, take your time.
I am here to test [emoji6]

Silly logic error, try these now and should be ok: https://jenkins.kodi.tv/blue/organizatio.../artifacts

Tested on windows and now it works as it should and the issue is solved!
Here is the log starting kodi offline -> server error is returned: https://paste.kodi.tv/qisiwiyoza.kodi
And the Log starting online again: https://paste.kodi.tv/asomucejew.kodi

But, as on Zattoo addon, i have to restart kodi to get the PVR addon working again, when once started kodi offline.
An connection async handling would be the cherry on top 

Anyway, i think the code can be merged and released.
Thanks a lot for fixing this so fast.
pOpY

[phunkyfish]

No problem @popy. I’ll merge it on Sunday.

FYI you will need to manually update once released otherwise you’ll be stuck on the zip version.

[popy]

No problem @popy. I’ll merge it on Sunday.

FYI you will need to manually update once released otherwise you’ll be stuck on the zip version.

ok, thx for the hint.