Beta Milkdrop viz causes crash when music track resolution changes - v19 Beta 2
#1
i am having a strange error.

windows 10 x64, full install, current nightly as of this post, but has been happening for about a month.

i have some music that is hi-res compared to CD rips, i.e. 16bit/42kHz versus 24bit/96kHz.  if the resolution changes during playback, Kodi crashes with a memory reference error.  for example, i put on party mode, then go an pick a hi-res track to play next, it will play the hi-res track, but crash.  the song will finish playing too which is very odd, but it will not play anything afterwards and i need to ok the error and re-launch kodi.

debug log: https://paste.kodi.tv/yotifahumu.kodi
DMP file: https://drive.google.com/file/d/1kTk_ZsR...sp=sharing

there is a stacktrace file with nothing really inside:
Thread 5668 (process 4404)
# 0


let me know what you think.  can provide sample files if necessary.

thanks!!
Reply
#2
Can you try with viz disabled, milkdrop is producing errors in the log, so let's exclude that first
Reply
#3
looks good without milkdrop.  i mean i don't really need milkdrop but its nice; wish that the lyrics plugin was less overwhelming to the whole thing, but its great too just could use some better skin integration but that's a digression.

did not crash, log file here:
https://paste.kodi.tv/esipaloloj.kodi

high res file was Jonathan Bree if that helps find the space in the log.

2021-01-04 14:55:22.733 T:9052     INFO <general>: PAPlayer:TonguerocessStream - Stream Finished
2021-01-04 14:55:22.744 T:9052    DEBUG <general>: CApplication::OnPlayBackStarted: CApplication::OnPlayBackStarted
2021-01-04 14:55:22.744 T:9052    DEBUG <general>: CApplication::OnAVStarted: CApplication::OnAVStarted
2021-01-04 14:55:22.746 T:1020    DEBUG <general>: CMusicGUIInfo::InitCurrentItem(musicdb://artists/1942/255/-2/2795.flac?albumartistsonly=true&albumid=255&artistid=1942)
2021-01-04 14:55:22.750 T:1020    DEBUG <general>: SELECT albumview.*,albumartistview.*  FROM albumview  JOIN albumartistview ON albumview.idAlbum = albumartistview.idAlbum  WHERE albumview.idAlbum = 255  ORDER BY albumartistview.iOrder
2021-01-04 14:55:22.751 T:1020    DEBUG <general>: Loading additional tag info for file smb://CRONOS/cronos_full/music/proper/bree, jonathan/{2020} after the curtains close/jonathan bree - 01 - happy daze.flac
2021-01-04 14:55:22.755 T:1020    DEBUG <general>: unrecognized XipComment name: LABELNO
2021-01-04 14:55:22.755 T:1020    DEBUG <general>: unrecognized XipComment name: ORGANIZATION
2021-01-04 14:55:22.755 T:1020    DEBUG <general>: unrecognized XipComment name: TRACKTOTAL
2021-01-04 14:55:22.755 T:1020    DEBUG <general>: unrecognized XipComment name: URL
2021-01-04 14:55:22.755 T:1020    DEBUG <general>: CPlayerGUIInfo::InitCurrentItem(musicdb://artists/1942/255/-2/2795.flac?albumartistsonly=true&albumid=255&artistid=1942)
2021-01-04 14:55:22.756 T:4416    DEBUG <UPNP::BuildObject>: Building didl for object 'musicdb://artists/1942/255/-2/2795.flac?albumartistsonly=true&albumid=255&artistid=1942'
2021-01-04 14:55:22.856 T:1020    DEBUG <general>: ------ Window Init (DialogBusy.xml) ------
2021-01-04 14:55:22.892 T:1020    DEBUG <general>: ------ Window Deinit (DialogBusy.xml) ------
2021-01-04 14:55:22.979 T:1020    DEBUG <general>: ------ Window Init (C:\Users\doug\AppData\Roaming\Kodi\addons\script.cu.lrclyrics\resources\skins\Default\1080i\script-cu-lrclyrics-main.xml) ------
2021-01-04 14:55:22.979 T:1020     INFO <general>: Loading skin file: C:\Users\doug\AppData\Roaming\Kodi\addons\script.cu.lrclyrics\resources\skins\Default\1080i\script-cu-lrclyrics-main.xml, load type: LOAD_ON_GUI_INIT
2021-01-04 14:55:23.173 T:2584     INFO <general>: CActiveAESink::OpenSink - initialize sink
2021-01-04 14:55:23.229 T:2584    DEBUG <general>: CActiveAESink::OpenSink - trying to open device WASAPI:{5526C728-8A1F-478D-A9CD-977BE2D6F04C}
2021-01-04 14:55:23.261 T:2584     INFO <general>: CAESinkWASAPI::InitializeExclusive: WASAPI Exclusive Mode Sink Initialized using: AE_FMT_S24NE4MSB, 96000, 2

(edit: love how the emoji snuck in)
Reply
#4
Don't know anything about binary addons, but I do know there have been a lot of changes on how binary addons interact with Kodi so probably not a surprise if Milkdrop has an issue.

scott s.
.
Reply
#5
so what should be next step?  its in beta, maybe block the add-on until it doesn't have an issue?

can you reproduce?  i am win10x64 would be good to see it happen on other OS?

edit: can provide file types if necessary, just let me know.
Reply
#6
Did you try 32bit?  64bit Milk Drop never worked for me so I gave up on it in Leia.

Martin
Reply
#7
(2021-01-05, 02:33)emveepee Wrote: Did you try 32bit?  64bit Milk Drop never worked for me so I gave up on it in Leia.

Martin
I have repeated your crash
My config Win x64 2004 Kodi 19 nightly 210104
Test tracks
1 Flac / 2.0 ch / 88.2 kHz / 2439 kbps / 24 bit
2 Flac / 2.0 ch / 352.8 kHz / 10917 kbps / 24 bit
3 Flac / 2.0 ch / 44.1 kHz / 707 kbps / 16 bit

There definitely is a problem switching in these files, just going between 1 and 2 and back to 1 crashes with milkdrop and also going from 2 to 1 and back to 2.  Shadertoy and Spectrum don't crash but I can hear a glitch in playback in about the last second at the end of the second of the played files (i.e., same place where Kodi crashes with Milkdrop).  I also hear the glitch at the same spot with no visualization enabled.

I got my test files from here (AFAICT there is no problem using these)
http://www.lindberg.no/hires/test/2L-038...4b_01.flac
http://www.lindberg.no/hires/test/2L-038...4b_01.flac
http://www.lindberg.no/hires/test/2L-038...6b_01.flac


scott s.
.
Reply
#8
It's not my crash, I was suggesting it was a 64 Milkdrop issue that have been reported for a while by and the OP should try 32 bit Kodi.

Martin
Reply
#9
@afedchin are you aware of this issue in Milkdrop, perhaps you can fix.
Reply
#10
(2021-01-06, 02:10)emveepee Wrote: It's not my crash, I was suggesting it was a 64 Milkdrop issue that have been reported for a while by and the OP should try 32 bit Kodi.

Martin
Understood.

scott s.
.
Reply
#11
(2021-01-06, 14:13)DaveBlake Wrote: @afedchin are you aware of this issue in Milkdrop, perhaps you can fix.

no, I know nothing about this. If I will have a some spare time I try to reproduce and fix it.
Reply
#12
(2021-01-09, 21:50)afedchin Wrote:
(2021-01-06, 14:13)DaveBlake Wrote: @afedchin are you aware of this issue in Milkdrop, perhaps you can fix.

no, I know nothing about this. If I will have a some spare time I try to reproduce and fix it.
Note that I think I hear an audio glitch at the end of playback of the second "hi res" file, even with no visualization or one other than Milkdrop (which doesn't result in crash).

scott s.
.
Reply
#13
Thanks to afedchin and fixed version of Milkdrop for Matrix is now available https://github.com/xbmc/visualization.milkdrop

@scott967 @koawmfot can you also test Milkdrop2 for any similar issues
Reply

Logout Mark Read Team Forum Stats Members Help
Milkdrop viz causes crash when music track resolution changes - v19 Beta 20