2021-11-07, 17:25
@jogal
Finally i didn't use your last change on RAW method only cause it's better to have your fantastic Atmos patch on both methods (IEC and RAW).
Unfortunately, i was not able to find a way to fix the a/v sync issue in atmos without modify the common part (Audio Engine).
But i did some changes in the common part to impact only the android platform, no impact with the other plateforms.
Moreover, to solve all the video stutters we have (i still had some stutters with IEC and 1080p/DTS), i did another rollback in Android Audiotrack sink to have the same behavior than the 18.9 which is the latest known stable version for android.
It uses a part of the fritsch's fix too.
For the Atmos fix in common part, i checked the cpu usage on my shield during an 4K/Atmos movie and it's more or less the same load as the 18.9 version.
It's for me, the safiest code i can provide.
It's not risky because it's a part of the 18.9 code which work for most people.
And as there's no one to maintain the current code... it's better to do a partial rollback to the latest stable version until the new code issues have been totally resolved by someone who have time and knowledge (not me).
As explained by fritsch, maybe it will rollback some issues too like "Music Playing in Home-Screen of 5.1 flac will stutter" and it will increase the CPU load as it was before...
but what is the most important function in kodi ? The video player or the audio player ?
I already know that the former android developers won't agree ... but today it's a fact, the current android version is unusable if you want to use passthrough for the best audio experience (Atmos).
My lastest commit is available here
My latest test package for ARM64 can be downoaded here (installation is still done beside your current Kodi, package name is org.xbmc.kodi19)
I will do a PR for the master.... it's up to the Team Kodi now to decide to take care or not.
It's my last commit... as other android developers, i have no time to work on it, i did my best to help.
EDIT : the PR here
How to add the missing label and milestone ?
Finally i didn't use your last change on RAW method only cause it's better to have your fantastic Atmos patch on both methods (IEC and RAW).
Unfortunately, i was not able to find a way to fix the a/v sync issue in atmos without modify the common part (Audio Engine).
But i did some changes in the common part to impact only the android platform, no impact with the other plateforms.
Moreover, to solve all the video stutters we have (i still had some stutters with IEC and 1080p/DTS), i did another rollback in Android Audiotrack sink to have the same behavior than the 18.9 which is the latest known stable version for android.
It uses a part of the fritsch's fix too.
For the Atmos fix in common part, i checked the cpu usage on my shield during an 4K/Atmos movie and it's more or less the same load as the 18.9 version.
It's for me, the safiest code i can provide.
It's not risky because it's a part of the 18.9 code which work for most people.
And as there's no one to maintain the current code... it's better to do a partial rollback to the latest stable version until the new code issues have been totally resolved by someone who have time and knowledge (not me).
As explained by fritsch, maybe it will rollback some issues too like "Music Playing in Home-Screen of 5.1 flac will stutter" and it will increase the CPU load as it was before...
but what is the most important function in kodi ? The video player or the audio player ?
I already know that the former android developers won't agree ... but today it's a fact, the current android version is unusable if you want to use passthrough for the best audio experience (Atmos).
My lastest commit is available here
My latest test package for ARM64 can be downoaded here (installation is still done beside your current Kodi, package name is org.xbmc.kodi19)
I will do a PR for the master.... it's up to the Team Kodi now to decide to take care or not.
It's my last commit... as other android developers, i have no time to work on it, i did my best to help.
EDIT : the PR here
How to add the missing label and milestone ?