Posts: 26,215
Joined: Oct 2003
Reputation:
187
Looks good to me. The only thing I can think of that could go wrong is checking that GetChapter() returns 0 whenever there is no chapters (i.e. ensuring that chapterIdx is actually in the set [1 .. m_pFormatContext->chapters.size()])
Assuming that is OK, it looks fine. Mind checking?
Cheers,
Jonathan
Posts: 418
Joined: Oct 2004
Reputation:
0
Actually waldo22, checking the code I may or may not be completely accurate because the linuxport branch and trunk (which I believe the xbox builds still come from) have different code. I have not built a xbox build since my xbox is experiencing the Autumn of its years and doesn't work so well any more.
Ok so when xbmc wants to play something it needs a player, and that top level object is called the Player Core. XBOX has DVDPlayer, MPlayer, PAPlayer and maybe ModPlayer. By default xbox hardware prefers the mplayer core to the dvdplayer core. And I've just realized that you've already realized that you can override the default core with the "Play using..." context menu option sooooo you know all this already. But to finish the concept for academic purposes: then player core picks a demux, and the demux picks the codecs.
I guess the question is does the >| button chapter skip, right? Yeah it was added to trunk's ffmpeg demux in r13293 (May 28) and DVDPlayer in r13533 (Jun 11). It should be bound to the "skipplus" and "skipminus" actions in your remote map.
Posts: 418
Joined: Oct 2004
Reputation:
0
Any update on when this can get into SVN? [url=http://capnbry.net/~bmayland/fi/code/chaptername_support.diff]Link to patch again[url] for chapter name support in MKV files.
Posts: 788
Joined: Sep 2007
Reputation:
14
elupus,
Do you think you'll have time to roll this into the xbox build?
I'd send beer, but I think all the good stuff is already on your side of the Atlantic.
-Wes
Posts: 418
Joined: Oct 2004
Reputation:
0
I'll put a new patch against head in trac tomorrow morning. I would have done it when trac went back up but there was a conflict and I didn't have the time to look at it. I was afraid of making a sloppy patch so I held off.