[outleradam]

I am using your script as a working reference right now. I am having a cyclic boot issue after installing mini and then xbmc-live and drivers. http://forum.xbmc.org/showthread.php?p=5...post588849

I really hope you don't mind if I critique your code as I am going thorugh it.... It would be appreciated if you would go through mythicalLibrarian and post in my thread. https://mythicallibrarian.googlecode.com/svn/trunk/

I'm wondering why you didn't just go with something like this for package checking, which is POSIX compliant.

Code:

if which dialog >/dev/null; then
    echo "Verified dialog exists"
else
    test "$LinuxDep" = "1" && echo "Please install package 'dialog' on your system" || echo "Please obtain MacPorts and install package dialog"
     a="dialog "
fi


if which curl >/dev/null; then
    echo "Verified curl exists"
else
    test "$LinuxDep" = "1" && echo "Please install 'curl' on your system" || echo "Please obtain MacPorts and install package curl"
     c="curl "
fi
if which agrep >/dev/null; then
    echo "Verified agrep exists"
else
    test "$LinuxDep" = "1" && echo "Please install 'agrep' on your system" || echo "Please obtain MacPorts and install package agrep"
     d="agrep "
fi
if which notify-send >/dev/null; then
    echo "Verified libnotify-bin exists"
else
    echo "'libnotify-bin' is a non essential missing package on your system"
     test "$LinuxDep" = "1" && e="libnotify-bin "|| echo "This platform does not support Pop-up notifications.-OK"
fi


if which agrep>/dev/null && which curl>/dev/null && which dialog>/dev/null; then
    echo "All checks complete!!!"
else
    echo "the proper dependencies must be installed..."
     echo "The missing dependencies are $a$b$c$d$e"
     test "$LinuxDep" = "1" && echo "Debian based users run 'apt-get install $a$b$c$d$e" || echo "Please obtain MacPorts and install $a$b$c"........................

The function f_AgtB(){ } is a very crypitic title and cryptic functions should be kept away from


Documentation of the code would be nice. It helps out not only you, but others like me when I am trying to figure out what happened to my installation of XBMC.


You should wrap text in quotations so that it is compliant regardless of whatever the variable states.. No quotes also does not play well with my IDE (gedit)