[X3lectric]

I am using your script as a working reference right now. I am having a cyclic boot issue after installing mini and then xbmc-live and drivers. http://forum.xbmc.org/showthread.php?p=5...post588849

I really hope you don't mind if I critique your code as I am going thorugh it.... It would be appreciated if you would go through mythicalLibrarian and post in my thread. https://mythicallibrarian.googlecode.com/svn/trunk/

I'm wondering why you didn't just go with something like this for package checking, which is POSIX compliant.

Code:

if which dialog >/dev/null; then
    echo "Verified dialog exists"
else
    test "$LinuxDep" = "1" && echo "Please install package 'dialog' on your system" || echo "Please obtain MacPorts and install package dialog"
     a="dialog "
fi


if which curl >/dev/null; then
    echo "Verified curl exists"
else
    test "$LinuxDep" = "1" && echo "Please install 'curl' on your system" || echo "Please obtain MacPorts and install package curl"
     c="curl "
fi
if which agrep >/dev/null; then
    echo "Verified agrep exists"
else
    test "$LinuxDep" = "1" && echo "Please install 'agrep' on your system" || echo "Please obtain MacPorts and install package agrep"
     d="agrep "
fi
if which notify-send >/dev/null; then
    echo "Verified libnotify-bin exists"
else
    echo "'libnotify-bin' is a non essential missing package on your system"
     test "$LinuxDep" = "1" && e="libnotify-bin "|| echo "This platform does not support Pop-up notifications.-OK"
fi


if which agrep>/dev/null && which curl>/dev/null && which dialog>/dev/null; then
    echo "All checks complete!!!"
else
    echo "the proper dependencies must be installed..."
     echo "The missing dependencies are $a$b$c$d$e"
     test "$LinuxDep" = "1" && echo "Debian based users run 'apt-get install $a$b$c$d$e" || echo "Please obtain MacPorts and install $a$b$c"........................

Actually this way the script would not run because your only saying that package-A does not exist and telling user to go get it, user must do something before, IMO this is not refined enough.

The script determines what is it needs is installed and if not it gets it, user input not required as below.

Code:

if [ ! -e .dialogrc ]; then
wget http://dl.dropbox.com/u/4325533/XCI/dialogrc &>> ~/setup/logs/xci-script-upgrade.log
mv dialogrc .dialogrc &>> ~/setup/logs/xci-script-upgrade.log
fi

if [ "$(dpkg -s dialog | grep -i "Status:" | awk '{print $4}' 2>/dev/null)" != "installed" ]; then
    echo -e '\E[1;37m\033[1mInstalling Dialog...\033[0m'
    aptitude install dialog -y &>> ~/setup/logs/xci-installer.log
fi  
if [ "$(uname -a | grep -i "PAE")" != "" ]; then
    dialog --sleep 5 --colors --title "\Z1[ INFORMATION ]\Zn" --infobox "Sorry, you seem to be running a PAE kernel, and this script does not support it." 5 40
    exit 1
fi
if [ "$(dpkg -s wget | grep -i "Status:" | awk '{print $4}' 2>/dev/null)" != "installed" ]; then
    dialog --colors --title "\Z1[ INFORMATION ]\Zn" --infobox "     Installing required tools..." 3 45
    aptitude install wget -y &>> ~/setup/logs/xci-installer.log
fi  
if [ "$(dpkg -s pv | grep -i "Status:" | awk '{print $4}' 2>/dev/null)" != "installed" ]; then
    dialog --colors --title "\Z1[ INFORMATION ]\Zn" --infobox "     Installing required tools..." 3 45
    aptitude install pv -y &>> ~/setup/logs/xci-installer.log
fi  
if [ "$(dpkg -s bind9 | grep -i "Status:" | awk '{print $4}' 2>/dev/null)" != "installed" ]; then
    dialog --colors --title "\Z1[ INFORMATION ]\Zn" --infobox "     Installing required tools..." 3 45
    aptitude install bind9 -y &>> ~/setup/logs/xci-installer.log
fi  
if [ "$(dpkg -s tar | grep -i "Status:" | awk '{print $4}' 2>/dev/null)" != "installed" ]; then
    dialog --colors --title "\Z1[ INFORMATION ]\Zn" --infobox "     Installing required tools..." 3 45
    aptitude install tar -y &>> ~/setup/logs/xci-installer.log
fi  
if [ "$(dpkg -s pastebinit | grep -i "Status:" | awk '{print $4}' 2>/dev/null)" != "installed" ]; then
    dialog --colors --title "\Z1[ INFORMATION ]\Zn" --infobox "     Installing required tools..." 3 45
    aptitude install pastebinit -y &>> ~/setup/logs/xci-installer.log
fi

the above is all automatic, script starts and runs without interruptions or requiring user input.

The function f_AgtB(){ } is a very crypitic title and cryptic functions should be kept away from

*snip

You should wrap text in quotations so that it is compliant regardless of whatever the variable states.. No quotes also does not play well with my IDE (gedit)

I have posted about this on post #168 above this one

On the wiki side I agree its VERY incomplete and a great deal of what script does can be incorporated into a definitive how to, if your willing to do this I think its well worth it. you would do the community a good service by actually making the wiki really relevant. After all its not just getting xbmc to actually execute it about getting a fully working system from scratch.

The wiki is all over the place and I dont have time myself.