[cliffe]

Cliffe,

Took some time after work to remove my Capitalization 'bug' then add a more platform independant solution and fix my $#*! lookup issue. Meet version 1.14rc, due to me working on windows for this and so I can test it there, Eclipse formated the file differently with my new code so a patch file was all but impossible. I mostly likely made it worst when I tried to fix the formating but anyhoo...

New features (if accepted):
> --show-title-rename - uses tvdb lookup for proper title format. (replaces Text::Capitalize)
> added tvdb id support for shows that the ep lookup gets confused on, now you can use the tvdb id # for the sub name. ie. $#*! My Dad Says ep lookup now works with tvdb id.

Once again, sorry about the lack of patch file, tomorrow when I am rested again I can copy additions into a basic editor that won't mess with it's formating so I can make a useable patch file.

Here is my release candidate if you wish to look at it and implement.
Sorttv 1.14rc

First of all thanks for taking the time to do this. It is fantastic to get the code contribution. I look forward to incorporating these features into SortTV.

A few constructive comments: Please stick to the code style and layout used. I realise that spacing is a matter of preference, but as with contributing to any open source projects, it is polite to use the established style, or discuss changes. I agree with reformatting the eval lines (and maybe some other changes), but when submitting patches please try to stick with the current coding style. It also makes it hard to review feature changes, when you have made lots of unrelated changes.

Example of style (no need for blank lines in if statements these are the product of the forum):

Code:

if(condition1) {
[INDENT]statement;[/INDENT]
} elsif(condition2) {
[INDENT]statement;[/INDENT]
} else {
[INDENT]statement;
# one line if statements like the following could be turned into multi-line ones if the condition gets too long.
statement if condition3;[/INDENT]}

I can review changes to style separately, but please send your patch without style changes.

Update: I notice you mention your editor made some changes, so perhaps these are all the result of your text editor

Regarding the actual feature changes:

Please call the argument "--fetch-show-title" or something that can not imply that it forces a file rename.

Your version included this strange output:

Code:

DOWNLOAD: downloading images for CSI: Crime Scene Investigation
/Season 1ing season directory: /home/cliffe/Files/Media/TV/CSI- Crime Scene Investigation
DOWNLOAD: downloading season image for CSI: Crime Scene Investigation
Season 1 Episode 4.episode title for CSI: Crime Scene Investigation
- S01E04.avi- Crime Scene Investigationds/Unsorted/CSI s1e4.avi to /home/cliffe/Files/Media/TV/CSI- Crime Scene Investigation
Season 1 Episode 5.episode title for CSI: Crime Scene Investigation
- S01E05.avi- Crime Scene Investigationds/Unsorted/csi s1e5.avi to /home/cliffe/Files/Media/TV/CSI- Crime Scene Investigation

I look forward to the patch. Please create the patch using:

Code:

diff -u /path/to/sorttv.pl /path/to/your-new-version-of-sorttv.pl > sorttv.patch

You can use directories if you have made changes to all the files.
(or you can use git and pull the latest SortTV version from sourceforge)
Please only include feature changes. (i.e. don't include your own config file settings changes)

As you are probably aware, the command dos2unix can convert the Windows formatted file into a Linux formatted file.

Anyway, thanks again, I look forward to receiving a patch.