[jamontes]

Hi,

I've found a version problem that prevents Youtube, Vimeo, and BlipTv plugins from work on systems (like Fedora releases) where the XBMC comes from a GIT version.

For instance, at my local system (Fedora 16) the XBMC release reported by the API is "11.0 Git:Unknown".
The problem is located at the funtion getXBMCVersion() of "CommonFunctions.py" file of the script.module.parsedom module, which is used by the three above plugins.

So whenever I launch any of the three plugins mentioned, getXBMCVersion() cannot converts the string reported by the API to a float value (expected by getParameters() to know which version of XBMC is working with), and the whole plugin chrash.

I've collected the whole xbmc.log with the Vimeo plugin runing in debug mode so you can see the problem ( http://pastebin.com/TKAze6ya ). I've tested on Fedora 16 and Fedora 17 and found the same problem. However, I've tested on my Openelec (Eden flavour) Raspberry Pi and everything works fine (as the API reports "11.0", which can be converted to float to make the release comparison ).

In order to fix the problem, I've did a quick patch to get only the digits part from the string reported by the API at the getXBMCVersion() function of the script.module.parsedom module. This is the original fragment of code:

def getXBMCVersion():
>>>>log("", 3)
>>>>version = xbmc.getInfoLabel( "System.BuildVersion" )
>>>>log(version, 3)
>>>>if version.find("-") -1:
>>>>>>>>version = version[:version.find("-")]
>>>>version = float(version)
>>>>log(repr(version))
>>>>return version

And this is the (dirty and quick) patched version:
def getXBMCVersion():
>>>>log("", 3)
>>>>version = xbmc.getInfoLabel( "System.BuildVersion" )
>>>>log(version, 3)
>>>>#jamontes modified this:
>>>>version_pat = re.compile('^[0-9.]+')
>>>>version_num = version_pat.findall(version)[0]
>>>>#if version.find("-") -1:
>>>>>>>>#version = version[:version.find("-") -1]
>>>>version = float(version_num)
>>>>log(repr(version))
>>>>return version

I'm sorry for the dirty patch, as I'm new to python and XBMC plugins world. I hope you would fix it in a more ellegant way due to my lack of knowledge on python.

Many thanks in advance for all The Collective have done and kind regards,
jamontes