2010-11-29, 21:27
@Jimmeh - I noticed that yesterday after I pushed the update. I'll try and get those resolved tonight.
stoli Wrote:@Jimmeh - I noticed that yesterday after I pushed the update. I'll try and get those resolved tonight.
Before (not working):
923: <onup>593</onup>
924: <ondown>593</ondown>
After (working):
923: <onup>59</onup>
924: <ondown>7000</ondown>
Jimmeh Wrote:How's that for service
Thank you kindly sir *tips hat*.
filigran Wrote:I was looking about the skin trying to find inspiration while building my own, and stumbled upon this:
In episodes, 16x9 viewtype (id 59): Pressing down from the wraplist to the scrollbar (69) -> press up/down, nothing happens. Looking at the code, the onup/ondown values are messed up:
Line 923 and 924 in 720p/Viewtype_16x9.xml:
Might set the <ondown> to 59 too, like original Night, but IMO a menu that comes from the bottom should be accessible by going down at the bottom.PHP Code:Before (not working):
923: <onup>593</onup>
924: <ondown>593</ondown>
After (working):
923: <onup>59</onup>
924: <ondown>7000</ondown>
Btw, while testing out this bug I found that your font is missing the swedish (and finnish, but who cares about them. ) letter Å (small version å, å if using htmlentities ). You can see this by pressing down on movies/tvshows on home menu. In the sub menu there's an "R" for me (using swedish language) that seems to be a release year filtering. This should ofc be "ÅR" not "R". It's like seeing "AR" instead of "YEAR" for english. Doesn't really make sense.
Keep up the good work!
stoli Wrote:Fixed the up/down - thanks for that! And wouldn't you know that it is the one character missing from the font. I completely missed that it was missing that character. I'll keep my eyes open for yet another font - if anyone has a suggestion, I am more that open to ideas.
Thanks,
Jimmeh Wrote:Another small bug, when you turn subtitles on the caption reads "Subtitles ASS".
Guessing that wasn't intended