Is comskip supported via the addon?

  Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
Swifty Offline
Fan
Posts: 619
Joined: Nov 2008
Reputation: 5
Post: #1
Everything is pretty much in the title Smile

I have setup MePo to run all recordings through comskip, and enabled the configuration options in comskip to output edl files that XBMC should understand, but when I play my recordings, nothing gets skipped..

Is this something that should, or shouldn't be working via the addon at this point?
find quote
margro Offline
Fan
Posts: 654
Joined: Oct 2009
Reputation: 21
Location: The Netherlands
Post: #2
Not supported at the moment. The PVR API has no support for asking the PVR addon if there is a edl file for a recording.
There is a pull request pending for opdenkamp that adds this.

Developer of the MediaPortal PVR addon and the Argus-TV PVR-addon. Unofficial XBMC Windows builds with PVR.
http://www.scintilla.utwente.nl/~marcelg/xbmc
find quote
Swifty Offline
Fan
Posts: 619
Joined: Nov 2008
Reputation: 5
Post: #3
OK, thanks for clarifying :-)
find quote
danmer Offline
Junior Member
Posts: 11
Joined: Oct 2009
Reputation: 0
Post: #4
Sad(((
(This post was last modified: 2013-03-21 15:34 by danmer.)
find quote
tommywm22 Offline
Junior Member
Posts: 15
Joined: Jul 2012
Reputation: 0
Post: #5
But, you can utilize the edl file if you watch your recordings from your videos library.
find quote
margro Offline
Fan
Posts: 654
Joined: Oct 2009
Reputation: 21
Location: The Netherlands
Post: #6
It should also work with Frodo when XBMC and the MediaPortal TVServer backend are on the same machine. In that case, recording playback is done directly by XBMC. The MediaPortal PVR addon passes the local recording filename to XBMC in that case.

BTW. The required PVR API change for EDL support is already merged into XBMC master (Gotham alpha's). Next step for me is to setup comskip for testing purposes and extend the PVR addon accordingly.
Can somebody point me to a good manual for MediaPortal + comskip?

Developer of the MediaPortal PVR addon and the Argus-TV PVR-addon. Unofficial XBMC Windows builds with PVR.
http://www.scintilla.utwente.nl/~marcelg/xbmc
(This post was last modified: 2013-03-24 14:46 by margro.)
find quote
Swifty Offline
Fan
Posts: 619
Joined: Nov 2008
Reputation: 5
Post: #7
I had some fun getting comskip to play nice with my tvserver since if I had multiple recordings close together it would eat all my CPU as it processed the files concurrently, but since the comskip support in MP is pretty basic there is no way to limit this.

I put together a small app which basically queues the files and then passes them through comskip.
It's not super heavily tested, but its been running on my server for a few months without issue.. I'll drop you a PM with the link.
find quote
tommywm22 Offline
Junior Member
Posts: 15
Joined: Jul 2012
Reputation: 0
Post: #8
(2013-03-24 14:45)margro Wrote:  Can somebody point me to a good manual for MediaPortal + comskip?

In Media Portal you just have to enable it. I didn't change anything else. I think the only complete manual is the one on the ComSkip site. For me (USA) it has been working fine out of the box... I just made sure the EDL was enabled.

Thomas
(This post was last modified: 2013-04-02 18:13 by tommywm22.)
find quote
Schaussi Offline
Junior Member
Posts: 18
Joined: Mar 2013
Reputation: 0
Post: #9
margro, could you give us some information about the current state of this feature?
thank you
find quote
margro Offline
Fan
Posts: 654
Joined: Oct 2009
Reputation: 21
Location: The Netherlands
Post: #10
Current state is still the same. PVR API support is there in Gotham, but I haven't had the time to setup comskip myself and update the addon.
Patches from others to add it are welcome Wink

Developer of the MediaPortal PVR addon and the Argus-TV PVR-addon. Unofficial XBMC Windows builds with PVR.
http://www.scintilla.utwente.nl/~marcelg/xbmc
find quote
margro Offline
Fan
Posts: 654
Joined: Oct 2009
Reputation: 21
Location: The Netherlands
Post: #11
I just checked what the PVR API now offers with respect to EDL/comskip support and it is not possible to just pass a "moviename.txt" or "moviename.edl" file to XBMC.
According to the PVR API function documentation I have to feed XBMC with the individual EDL entries.
This basically means that I have to build an EDL parser first, which seems a bit double work, because XBMC itself already knows how to parse them. I just can't tell XBMC: "here is your Comskip/EDL file"
Therefore, my conclusion is that even the current Gotham PVR API does not provide me with the right functions to support Comskip/EDL in an easy way.

Developer of the MediaPortal PVR addon and the Argus-TV PVR-addon. Unofficial XBMC Windows builds with PVR.
http://www.scintilla.utwente.nl/~marcelg/xbmc
find quote
QueK9 Offline
Donor
Posts: 54
Joined: Jul 2013
Reputation: 1
Post: #12
(2013-07-28 14:59)margro Wrote:  I just checked what the PVR API now offers with respect to EDL/comskip support and it is not possible to just pass a "moviename.txt" or "moviename.edl" file to XBMC.
According to the PVR API function documentation I have to feed XBMC with the individual EDL entries.
This basically means that I have to build an EDL parser first, which seems a bit double work, because XBMC itself already knows how to parse them. I just can't tell XBMC: "here is your Comskip/EDL file"
Therefore, my conclusion is that even the current Gotham PVR API does not provide me with the right functions to support Comskip/EDL in an easy way.

That's disappointing, is this on the horizon to be implemented in the future?
find quote
QueK9 Offline
Donor
Posts: 54
Joined: Jul 2013
Reputation: 1
Post: #13
(2013-03-24 16:14)Swifty Wrote:  I had some fun getting comskip to play nice with my tvserver since if I had multiple recordings close together it would eat all my CPU as it processed the files concurrently, but since the comskip support in MP is pretty basic there is no way to limit this.

I put together a small app which basically queues the files and then passes them through comskip.
It's not super heavily tested, but its been running on my server for a few months without issue.. I'll drop you a PM with the link.

Would you care to share your app?
find quote
QueK9 Offline
Donor
Posts: 54
Joined: Jul 2013
Reputation: 1
Post: #14
I am the only one that wants com skipping? It appears that the issue is dead. Sad
find quote
Schaussi Offline
Junior Member
Posts: 18
Joined: Mar 2013
Reputation: 0
Post: #15
I am sure many people would like to have it. I understand that margro does not like to implement it with the current API options.
Hopefully the API gets optimized for this feature in the future.
find quote
Post Reply