[harryberlin]

I did read in Kodi 17, first you have to enable the slider to move itself.
Is it possible to get move the slider left by down and right by up key?

[Memphiz]

Which one?

[ronie]

it depends on the <orientation> tag of the slider control.

horizontal sliders use left/right to move the slider,
vertical ones use up/down.

there's no way to override that.

[harryberlin]

i meant, to extend the usual
up/down on vertical sliders with right/left
and
left/right on horizontal sliders with down/up
only when the sliders are enabled.

example:
1. enable a horizontal slider by select
2. press up to move right
3. press down to move left
4. press left to move left
5. press right to move right
6. disable the slider by select

or is it possible to set something in the default.xml?


empty signature

[ronie]

there's no way to override that.

as in not possible, can't do it, forget about it, nope, no way ;-)

[harryberlin]

pleaaaaase
i'm using a turn button to control kodi. would be cool.
like this:

Code:

def key_up():
    if slider.horizontal.enabled:
        key_right()

def key_down():
    if slider.horizontal.enabled:
        key_left()

def key_left():
    if slider.vertical.enabled:
        key_down()

def key_right():
    if slider.vertical.enabled:
        key_up()

is there a gui boolean or skin boolean to get? so i can switch the button events in my program?

[ronie]

* ronie gives up

[harryberlin]

would this do the trick?
GUISliderControl.cpp

Code:

bool CGUISliderControl::OnAction(const CAction &action)
{
  switch ( action.GetID() )
  {
  case ACTION_MOVE_LEFT:
    if (IsActive() && m_orientation == HORIZONTAL)
    {
      Move(-1);
      return true;
    }

    if (IsActive() && m_orientation == VERTICAL)
    {
      Move(-1);
      return true;
    }
    break;

  case ACTION_MOVE_RIGHT:
    if (IsActive() && m_orientation == HORIZONTAL)
    {
      Move(1);
      return true;
    }

    if (IsActive() && m_orientation == VERTICAL)
    {
      Move(1);
      return true;
    }
    break;

  case ACTION_MOVE_UP:
    if (IsActive() && m_orientation == HORIZONTAL)
    {
      Move(1);
      return true;
    }

    if (IsActive() && m_orientation == VERTICAL)
    {
      Move(1);
      return true;
    }
    break;

  case ACTION_MOVE_DOWN:
    if (IsActive() && m_orientation == HORIZONTAL)
    {
      Move(-1);
      return true;
    }

    if (IsActive() && m_orientation == VERTICAL)
    {
      Move(-1);
      return true;
    }
    break;


  case ACTION_SELECT_ITEM:
    if (m_rangeSelection)
      SwitchRangeSelector();
    return true;

  default:
    break;
  }
  return CGUIControl::OnAction(action);
}

[Memphiz]

Thats spaghetti

[harryberlin]

Which one?
Do you know why?

Bitte um Erklärung.

[da-anda]

f.e. this

Code:

if (IsActive() && m_orientation == HORIZONTAL)
    {
      Move(-1);
      return true;
    }

    if (IsActive() && m_orientation == VERTICAL)
    {
      Move(-1);
      return true;
    }
    break;

could be simplified to

Code:

if (IsActive())
    {
      Move(-1);
      return true;
    }
    break;

checking the orientation doesn't make much sense when you cover both orientations and perform the same action on both

[harryberlin]

you're right.
some hours behind, i got the same idea. but i thought, maybe it is really needed to check the orientation.
would this change work for my request, or is it trash?

at the moment i try to complie on rasp 2. but it runs very long time. i hope it is working.

[Memphiz]

I just called it spaghetti because its unreadable due to the form its visible here in tapatalk...

[harryberlin]

i tried to compile krypton on rasp 2 and windows 7 for a test it by myself, but i always get an error.