[scott967]

So the skin I work on provided a 720p folder with all the xml files. For Leia, I converted my layout to 1080/16:9 aspect. Following the example of Estuary (don't know why this is now preferred though) I placed all the new xml files in an xml folder, then modified addon.xml (again using Estuary as guidance) such that:

Code:

    <extension point="xbmc.gui.skin"  effectslowdown="0.75" debugging="false">
        <res width="1920" height="1440" aspect="4:3" default="false" folder="xml" />
        <res width="1920" height="1280" aspect="3:2" default="false" folder="xml" />
        <res width="1920" height="1200" aspect="16:10" default="false" folder="xml" />
        <res width="2040" height="1080" aspect="17:9" default="false" folder="xml" />
        <res width="1920" height="1080" aspect="16:9" default="true" folder="xml" />
        <res width="1280" height="720" aspect="16:9" default="true" folder="720p"/>
        <res width="2560" height="1080" aspect="21:9" default="false" folder="xml" />
    </extension>

For no particular reason, I left the 720p folder in place. My understanding of the intent of addon.xml, is that only when screen resolution is set to 1280x720 the 720p folder would be used; otherwise for any other screen resolution the xml folder is used.

However, in looking at logs when my skin is first loaded, Kodi logs:

First, under windows screen resolution is 1920,1080 (Kodi set to full screen using window)

Code:

DEBUG: CWinEventsWin32::WndProc: window resize event
DEBUG: CWinEventsWin32::WndProc: window move event
DEBUG: CWinSystemWin32::ResizeInternal - resizing due to size change (0,0,1920,1080 fullscreen)->(0,0,1920,1080 fullscreen)
DEBUG: CWinEventsWin32::WndProcWindow is active

Eventually my skin starts loading:

Code:

INFO: Loading custom window XMLs from skin path E:\Media\Kodi 18 A1 0629\portable_data\addons\skin.aeonmq5.leiamod\xml

then

Code:

INFO: Loading custom window XMLs from skin path E:\Media\Kodi 18 A1 0629\portable_data\addons\skin.aeonmq5.leiamod\720p
ERROR: No id specified or id already in use for custom window in CustomCode.xml
ERROR: No id specified or id already in use for custom window in CustomDelay.xml
...

So if I understand what is happening all my custom skin files from xml folder are read, then the 720p folder, even though there should be no need to load those files given the addon.xml says use xml folder for current screen resolution? Then Kodi errors on all the "custom" xml files that of course are duped in each of the two folders.

So I guess I have no understanding of how multiple skin xml resolution folders along with addon.xml are supposed to work?


scott s.
.

[kennywayne07]

Code:

    <extension point="xbmc.gui.skin"  effectslowdown="0.75" debugging="false">
        <res width="1920" height="1440" aspect="4:3" default="false" folder="xml" />
        <res width="1920" height="1280" aspect="3:2" default="false" folder="xml" />
        <res width="1920" height="1200" aspect="16:10" default="false" folder="xml" />
        <res width="2040" height="1080" aspect="17:9" default="false" folder="xml" />
        <res width="1920" height="1080" aspect="16:9" default="true" folder="xml" />
        <res width="1280" height="720" aspect="16:9" default="true" folder="720p"/>
        <res width="2560" height="1080" aspect="21:9" default="false" folder="xml" />
    </extension>

I have zero experience with this. So this is more of a question than an answer. Should both of the lines with aspect="16:9" have default="true"?

[Hitcher]

Just remove the 720p folder as Kodi will simply scale the 1080 code down to 720 if that resolution is used.

PS: As for naming it XML now that's just down to the skinner's choice.

[jurialmunkey]

Just remove the 720p folder as Kodi will simply scale the 1080 code down to 720 if that resolution is used.

I think he wants to retain the 720p folder for that resolution though.
I'm guessing the errors are because two different resolutions are both set to default="true"

[scott967]

Just remove the 720p folder as Kodi will simply scale the 1080 code down to 720 if that resolution is used.

I think he wants to retain the 720p folder for that resolution though.
I'm guessing the errors are because two different resolutions are both set to default="true"

Yes, thanks both for pointing out the bad copy/paste. It's interesting that with the 2 defaults it attempted to load both initially. Not sure I see the logic of that. I left the 720p folder so I could do some A/B testing of a couple things in the new resolution version. I take it there isn't any real reason to have more than one 16:9 aspect version of the skin? I couldn't tell any advantage one way or the other, though I haven't really tried to fine tune the 1080 version to take advantage of the increased resolution. At 10 feet I'm not sure it would make any sense.

scott s.
.

[jurialmunkey]

I take it there isn't any real reason to have more than one 16:9 aspect version of the skin? I couldn't tell any advantage one way or the other, though I haven't really tried to fine tune the 1080 version to take advantage of the increased resolution. At 10 feet I'm not sure it would make any sense.

Yeah I don't bother with anything other than 1080.
However, there is some advantage related to textures in having multiple versions -- particularly if there are textures that need to be pixel perfect like separator lines.

That being said, considering how cheap led tvs are now I would be surprised if there are all that many people running 720p any more, and those who are I imagine are not big sticklers for that sort of thing -- particularly, as you said, at 10 feet away.