2017-08-11, 19:40
There already were some discussions on how replay should be implemented for PVR addons:
Thread: https://forum.kodi.tv/showthread.php?tid=316999
PR: https://github.com/xbmc/xbmc/pull/10363
The PR extends the API to handle replay on their own.
@ksooo proposed to implement replay as recordings. To try this approach I implemented a small POC based on pvr.zattoo. Here are my findings.
Im my test, there are ~50'000 replay entries leading to ~50'000 recordings (in their own directory). Kodi is running on a Linux notebook with Core i7. Here some observations:
Loading time: On every refresh of the recordings, there is an additional delay of about 5 seconds. This is less than I expected but other devices will probably take longer. Opening the Recordings stream is still instantly.
Memory consumption:
after loading the replay-recordings, Kodi needs about 120MB more RAM. This will probably an issue for smaller devices.
Visual:
Every show now has its play arrow:
The virtual folder shows up in the recordings. Opening it, takes about 5-10 seconds.
Implementation:
Only in the addon. There were no changes to Kodi required to get it working, but in my opinion, some special handling should be added to Kodi to improve the experience with replay recordings.
Which way do you think we should go?
I am still the opinion that the implementation as recordings has too many drawbacks compared to the API extension (2 additional functions).
Thread: https://forum.kodi.tv/showthread.php?tid=316999
PR: https://github.com/xbmc/xbmc/pull/10363
The PR extends the API to handle replay on their own.
@ksooo proposed to implement replay as recordings. To try this approach I implemented a small POC based on pvr.zattoo. Here are my findings.
Im my test, there are ~50'000 replay entries leading to ~50'000 recordings (in their own directory). Kodi is running on a Linux notebook with Core i7. Here some observations:
Loading time: On every refresh of the recordings, there is an additional delay of about 5 seconds. This is less than I expected but other devices will probably take longer. Opening the Recordings stream is still instantly.
Memory consumption:
Code:
RSS value from ps
pre-replay 374928
post-replay 495456Visual:
Every show now has its play arrow:
The virtual folder shows up in the recordings. Opening it, takes about 5-10 seconds.
Implementation:
Only in the addon. There were no changes to Kodi required to get it working, but in my opinion, some special handling should be added to Kodi to improve the experience with replay recordings.
Which way do you think we should go?
I am still the opinion that the implementation as recordings has too many drawbacks compared to the API extension (2 additional functions).
