2009-07-05, 12:13
Hi there,
I'm just embarking on my first piece of c++ and xbmc coding and could do with some help.
I'm trying to add RTMP seek and pause functionality as described over here.
I think I'm pretty much there with getting the basics of the seek working but could do with some help enhancing it and getting the pause working. If anybody can help or wants to take a look I've got my code and patches I can send through.
What I've done so far:
The RTMP player now seeks to the correct point - whilst it is buffering the new point in the stream it will continue to play. The switch over happens after a lag. (This is due to not setting flushing stream buffers completely, more below).
What I want to achieve:
1. Buffer correctly when seeking:
I'd like make the following happen: When you seek the player stops playing and stops requesting packets. We then start buffering the stream at the selected seek point and switch to playing that stream when the buffering is complete.
This looks like it should happen automatically if we set the flush parameter of CDVDMsgPlayerSeek to true - however doing this causes a video playback problem I haven't been able to get to the bottom of. Audio is fine, video gets jumbled. Error I get is:
2. Allow multiple seek steps to used.
By this I mean you can press up on your remote 4 times and we will seek 40 minutes forward (i.e. 4 big steps).
In order to do this we need to keep track of previous requests that have been made. Can I (and should I) keep track of this in a private class member? I'm a tad wary as this is in DVDPlayer.seek,
3. Pause and play
I think this is a noob c++ casting question, sorry. For RTMP streams we need to pass the current play time to pause and a second parameter to tell it if it pausing or resuming. So in CDVDPlayer:
ause() I want to do something like I can't get this working though (as CDVDInputStreamRTMP does not have a constructor with.
Apologies for the essay!
I'm just embarking on my first piece of c++ and xbmc coding and could do with some help.
I'm trying to add RTMP seek and pause functionality as described over here.
I think I'm pretty much there with getting the basics of the seek working but could do with some help enhancing it and getting the pause working. If anybody can help or wants to take a look I've got my code and patches I can send through.
What I've done so far:
The RTMP player now seeks to the correct point - whilst it is buffering the new point in the stream it will continue to play. The switch over happens after a lag. (This is due to not setting flushing stream buffers completely, more below).
What I want to achieve:
1. Buffer correctly when seeking:
I'd like make the following happen: When you seek the player stops playing and stops requesting packets. We then start buffering the stream at the selected seek point and switch to playing that stream when the buffering is complete.
This looks like it should happen automatically if we set the flush parameter of CDVDMsgPlayerSeek to true - however doing this causes a video playback problem I haven't been able to get to the bottom of. Audio is fine, video gets jumbled. Error I get is:
Code:
CDVDVideoCodecFFmpeg::Decode - avcodec_decode_video returned failure
CDVDPlayerVideo - video decoder returned error
ffmpeg[9C]: [vp6f] pic->data[0]!=NULL in avcodec_default_get_buffer
ffmpeg[9C]: [vp6f] get_buffer() failed2. Allow multiple seek steps to used.
By this I mean you can press up on your remote 4 times and we will seek 40 minutes forward (i.e. 4 big steps).
In order to do this we need to keep track of previous requests that have been made. Can I (and should I) keep track of this in a private class member? I'm a tad wary as this is in DVDPlayer.seek,
3. Pause and play
I think this is a noob c++ casting question, sorry. For RTMP streams we need to pass the current play time to pause and a second parameter to tell it if it pausing or resuming. So in CDVDPlayer:
ause() I want to do something like Code:
((CDVDInputStreamRTMP*)m_pInput)->Pause(GetTime, true);Apologies for the essay!
