[Rich.T.]

@rob_webset,

v1.2.3 on Windows 7:

I'm getting some interesting errors in the log.
Notice the mixture of \ and /

Code:

19:14:19 T:6632  NOTICE: DvdExtras : finding extras for start_theme
19:14:19 T:7136   DEBUG: Activating window ID: 10138
19:14:19 T:7136   DEBUG: ------ Window Init (DialogBusy.xml) ------
19:14:19 T:6632  NOTICE: DvdExtras : Checking existence for /Extras/
19:14:19 T:6632   ERROR: XFILE::CDirectory::GetDirectory - Error getting

Code:

19:14:23 T:7476  NOTICE: DvdExtras : Path: C:\Users\Richard\AppData\Roaming\XBMC\addons\script.dvdextras
19:14:23 T:7476  NOTICE: DvdExtras : finding extras for D:\XBMC\Movies\District 9 (2009)\District.9.2009.Bluray.1080p.DTS-HD-7.1.x264.MKV
19:14:23 T:7476  NOTICE: DvdExtras : Checking existence for D:\XBMC\Movies\District 9 (2009)/Extras/
19:14:23 T:7136   DEBUG: Activating window ID: 10138
19:14:23 T:7136   DEBUG: ------ Window Init (DialogBusy.xml) ------
19:14:23 T:7476  NOTICE: DvdExtras : Nested check in directory: D:\XBMC\Movies\District 9 (2009)/Extras/
19:14:23 T:7136   DEBUG: ------ Window Init (DialogOK.xml) ------
19:14:23 T:7136   DEBUG: ------ Window Deinit (DialogBusy.xml) ------

Code:

19:07:49 T:6324  NOTICE: DvdExtras : Checking existence for D:\XBMC\TV\Hannibal\Season 1/Extras/
19:07:49 T:5912   DEBUG: Activating window ID: 10138
19:07:49 T:5912   DEBUG: ------ Window Init (DialogBusy.xml) ------
19:07:49 T:6324  NOTICE: DvdExtras : Nested check in directory: D:\XBMC\TV\Hannibal\Season 1/Extras/

...

I kept getting this error, so I checked back through the code and found that it needed changing in a couple of places in DVDExtras.py:

Line 138:

Code:

extrasDir = basepath + "/" + xbmcaddon.Addon().getSetting( "extrasDirName" ) + "/"

needed to change to:

Code:

extrasDir = basepath + "\\" + xbmcaddon.Addon().getSetting( "extrasDirName" ) + "\\"

and

Line 178:

Code:

dirpath = basepath + "/" + dirname + "/"

needed to change to:

Code:

dirpath = basepath + "\\" + dirname + "\\"

I believe this should make the code functional on Windows systems at least, but might break it for Unix.
Can anyone else confirm this?
My guess is that the testers reporting success above are running XBMC on Mac or Linux; my test system here is on Windows 7.

I'm going to have to check.

Rich.