[ronie]

2016-10-18 videowindow/visualization controls

many skins will use a videowindow control to display the currently playing video in the background.
this is a good thing, but you need to make sure that there's only 1 videowindow visible at all times.

when two videowindow controls are visible at the same time, kodi will have to render the video twice
and this will lead to issues, such as stuttering and high cpu usage.

so here's a few don'ts:
- don't add a small video preview window in the live-tv are if you already have the video as a fullscreen background
- don't use videowindow controls in dialogs (dialogs are rendered on top of windows that already may have a videowindow control)
- be aware that the slideshow window is actually a dialog and has a built-in videowindow (kodi supports to have videos in the picture slideshow)

and here's the do's:
- make sure you hide your videowindow controls when the slideshow is active (<visible>!SlideShow.IsActive</visible>)


... the same applies to any visualization controls.


pull request: https://github.com/xbmc/xbmc/pull/10720