2017-10-09, 21:15
(2017-10-09, 19:41)ZERO Wrote: It does not work, in order to support reading from extrafanart folders you must point to the directory directly. This is from the first implementation of extrafanart folders from years back. Later on some scrappers support pulling images directly into the database but such a feature is not supported for anime. The only way to have extrafanart for that is to add it yourself.
There is also a problem with the Image_Background when used at the episode level. Because the method uses ListItem.Art(fanart) it returns "Returns the fanart image of the currently selected item", as a result if you select the back button in the episode view it will not load the correct image (I assume it will load the fall back image in this case if configured). To correct this the variable Fanart.Image must be used in it's place as that will load " Fanart image for the parent TV Show ". When using Fanart.Image instead of Image_Background the content loads as expected. I can modify Image_Background (adding at line 170) to have the following line added for compatibility if you want:
<value condition="Control.IsVisible(513)">$INFO[Fanart.Image]</value>
I just wanted to avoid modifying any stock includes unless explicitly told to do so.
Unfortunately, it is impossible for me to test any other way of loading extrafanart images. From what I see many of those fanart download mods that auto download content are able to place it or do place the files in an extrafanart folder at the local directory of the media if configured to do so. This is the only implementation of extra fan art I can support. If users do not have this folder it will not effect the skin, they will just get one image in this display mode instead of multiple ones.
If someone wants to add a control to support another way of loading extrafan art they can once I post the final code up; unfortunately it is irresponsible for me to try to add code for something that I can not test and verify works.
Something is definitely not as it should be. The most popular skins for Kodi all implement Skin Helper for extrafanart retrieval almost exclusively, as it works regardless of the specific option used, be it direct, in-cache artwork management, or the extrafanart folder implementation. In fact, Marcel has made it like that specifically so that it would be viable as a universal solution. The add-on checks for extrafanart folders and their content within the library structure and acts accordingly. Everything is automatic, and seamless. This goes for Artwork Beef as well and as a nitpicker, I can confirm that both have proper extrafanart rotation across all levels - show, season and episode. I'm not sure why anime wouldn't work within that framework, as I have no experience there, but I'm fairly certain that there are anime users that would've complained if that were so?
There's a chance that for whatever reason the proper conditions in the includes aren't being triggered, which causes the proper method to be skipped. Before anything else, could you try setting $INFO[Window(Home).Property(SkinHelper.ListItem.Art.ExtraFanArt)] and see if that displays the proper artwork? If it does, we'll know that the mechanism works and then all that would remain would be to find out what's wrong with the conditions. The problem with a direct filepath implementation is that it will probably conflict with all other methods, so many skin users will end up with conflicting requirements for the same thing. Some users will get to the point of having to radically change their artwork organisation or usage just to be able to use two view-types within one skin. That is certain to cause massive confusion and a host of complaints about it not working for some and working for others, and I'd like to avoid that if possible.