2023-12-08, 03:34
(2023-12-08, 01:42)manfeed Wrote:(2023-12-08, 01:01)jurialmunkey Wrote: What's on line 4 in your favourites file?That's the problem! I'm seeing that now, in Omega, whenever I add a new favourite a NUL character gets added at the end of the file...
That sounds like a Kodi bug. Probably should be reported on xbmc github as NUL is not a valid character in XML schema:
https://en.wikipedia.org/wiki/Valid_characters_in_XML Wrote:Note that the code point U+0000, assigned to the null control character, is the only character encoded in Unicode and ISO/IEC 10646 that is always invalid in any XML 1.0 and 1.1 document.
As far as I understand, C++ string literals use NUL character terminations - so I'm guessing one has crept in somewhere with the code changes to use favouritesbrowser.
If that is fixed in core, I'm doubtful that any code changes are needed for skinshortcuts at all -- updating the shortcut to use favouritesbrowser can be done with the override I mentioned before (and that's a better approach than touching library.py because override will automatically update existing shortcut setups with the new path).