Login at Kodi Home

FernetMenta · 2013-01-30, 22:27

That is an interesting question. Doing so would mean that you might lose content when you have paused playback. Consider the case that you have just paused a movie 5 minutes before end, then you have to leave for 30 min and the buffer gets overwritten. You would be disappointed.
There's also a worst case for the other solution.

FernetMenta · 2013-01-31, 09:04

We could make this configurable, then the user can choose which death to die.

Nachteule · 2013-01-31, 16:34

Yes, good idea. Both ways have their pro's and con's.
But the better way for user is: newer let the buffer overrun! I tested it yesterday many times and the result was disappointing.
Moving across the position with lost data will confusing xbmc again. The extreme situation was pressing BigStepBack moves forward, pressing BigStepForward moves 3min (permanently) instead of 5min, pressing StepBack does nothing again. It is currently totally unpredictable what happens after a buffer overrun occurs.
I think it would be very difficult to solve this problem, but we should think about a good strategy in such cases.

FernetMenta · 2013-01-31, 19:50

You are right, gaps in the buffer are not easy to handle. Currently a gap in the buffer triggers dvdplayer setting a different offset. This offset is ignored on further seeks -> game over.
But this should change after: https://github.com/xbmc/xbmc/pull/2127

Nachteule · 2013-02-01, 18:03

Oh, good news.

Hopefully it will be working soon, so i'm waiting with further tests until it is available.

FernetMenta · 2013-02-02, 16:14

I pulled those patches to my master branch if you want to continue your tests: https://github.com/FernetMenta/xbmc/commits/master

te36 · 2013-02-04, 10:55

My priority as a user is timeshift on a recording that is still in progress. I do not know the VNSI protocol, but i would hope that this is also the easiest option to implement. Maybe XMBC could simply re-check the length of the file when it has reached playing out to -30 seconds of the currently known length of the file.

FernetMenta · 2013-02-04, 11:09

See post #29. Recordings in progress will be started by starting playback on the channel.

FernetMenta · 2013-02-05, 20:21

Nachteule, seeking seems to be broken with recent changes from mainline. Did you observe the same?

Nachteule · 2013-02-05, 23:19

No, not yet. I'm still using your osd branch and not the mainline and merged the patches from elupus into osd.
If i take your mainline xbmc branch, addon refuses to start

Nachteule · 2013-02-06, 18:37

(2013-01-31, 19:50)FernetMenta Wrote: You are right, gaps in the buffer are not easy to handle. Currently a gap in the buffer triggers dvdplayer setting a different offset. This offset is ignored on further seeks -> game over.
But this should change after: https://github.com/xbmc/xbmc/pull/2127

I applied theese patches to your osd branch and tested timeshift buffer overruns with this version. And what should i say, it works perfect now on my system Smile

FernetMenta · 2013-02-06, 22:08

hmm, I would have expected that those patches conflict on top of my osd branch. I need this additional patch to make it work:
https://github.com/FernetMenta/xbmc/tree/pvrseek

What's the problem with my master. Most recent version I work on is my master of xmbc and vnsi4 of pvr-addons. All three components are requires. vnsi plugin is renamed to vnsiserver4

Currently I do tests with the file buffer (not pushed yet)

jobe · 2013-02-07, 11:40

Hi FernetMenta,
is your master branch compatible with Frodo final? Or should opdenkamps repo be used for Frodo final?

Thanks for clarification.

FernetMenta · 2013-02-07, 12:58

For Frodo use this repo (and branch) for the addons: https://github.com/opdenkamp/xbmc-pvr-addons/tree/frodo

There will be a new version of vnsi available in opendenkamp master soon: https://github.com/FernetMenta/xbmc-pvr-.../tree/vnsi
(this is renamed to vnsiserver3, see sticky post)

btw: how is this related to timeshift Smile

jobe · 2013-02-07, 15:13

Oh, yes, sorry I just read your info on timeshift and you pointed out, that the most recent version is your master branch. So I wanted to know, if this will work with frodo final, to get timeshift to work.

Kind regards,
Jobe