• 1
  • 2
  • 3
  • 4(current)
  • 5
  • 6
  • 8
v18 Whitelist modes missing?
#46
Could you please try: 5414f7e <- that's not a solution I just want to know if I coded it right. I will revert the offending commit that forces this misbehaviour and I am currently rebuilding.
First decide what functions / features you expect from a system. Then decide for the hardware. Don't waste your money on crap.
Reply
#47
(2018-06-30, 20:47)fritsch Wrote:
(2018-06-30, 20:42)noggin Wrote:
(2018-06-30, 20:32)fritsch Wrote: Wait a moment. The 3840x2160 at 50 hz is your DESKTOP resolution right? So kodi is actually running that, right? Then it is fully clear why it is missing. Cause the whitelist only shows the CUSTOM_MODES not the DESKTOP_MODE.
OK - but then when I play 2160p50 without it selected in the Whitelist it doesn't run in 2160p50 it drops to 1080p50 - the only way I could get 2160p50 was to not have a whitelist.

Removing the desktop resolution/frame rate combo from the whitelist is also really unintuitive anyway isn't it?   
 I did not code it to be honest. You start kodi in 3840x2160 at 50 right? After that you manually change kodi resolution to 1920x1080 at 50? or do you keep it at 3840x2160?  
 I used to do that - but was trying the new BBC UHD iPlayer streams on the Shield TV.  Had my default (aka desktop) resolution at 3840x2160p50 and manually whitelist selected 3840x2160, 1920x1080 and 1280x720 frame rates I also wanted to use.  When I tried playing 2160p50 streams it didn't stay at 2160p50 - I assumed because it wasn't in the whitelist - and went to 1080p50 instead.
Reply
#48
(2018-06-30, 20:50)noggin Wrote:
(2018-06-30, 20:47)fritsch Wrote:
(2018-06-30, 20:42)noggin Wrote: OK - but then when I play 2160p50 without it selected in the Whitelist it doesn't run in 2160p50 it drops to 1080p50 - the only way I could get 2160p50 was to not have a whitelist.

Removing the desktop resolution/frame rate combo from the whitelist is also really unintuitive anyway isn't it?  
 I did not code it to be honest. You start kodi in 3840x2160 at 50 right? After that you manually change kodi resolution to 1920x1080 at 50? or do you keep it at 3840x2160?  
 I used to do that - but was trying the new BBC UHD iPlayer streams on the Shield TV.  Had my default (aka desktop) resolution at 3840x2160p and manually whitelist selected 3840x2160, 1920x1080 and 1280x720 frame rates I also wanted to use.  When I tried playing 2160p50 streams it didn't select 2160p50 - I assumed because it wasn't in the whitelist - and went to 1080p50 instead. 
 So - now you have a hidden bug agenda here :-) So even WITH the correct resolution in whitelist it does not switch to it?
First decide what functions / features you expect from a system. Then decide for the hardware. Don't waste your money on crap.
Reply
#49
If my currently building version fixes it, the reason is: https://github.com/xbmc/xbmc/pull/13899/...66f0c9125a and the fix suggested here: https://github.com/xbmc/xbmc/pull/13904 does not fix it.

I pinged the devs on that ... just 3 hours wasted on code reading :-)
First decide what functions / features you expect from a system. Then decide for the hardware. Don't waste your money on crap.
Reply
#50
(2018-06-30, 20:52)fritsch Wrote:
(2018-06-30, 20:50)noggin Wrote:
(2018-06-30, 20:47)fritsch Wrote:  I did not code it to be honest. You start kodi in 3840x2160 at 50 right? After that you manually change kodi resolution to 1920x1080 at 50? or do you keep it at 3840x2160?  
 I used to do that - but was trying the new BBC UHD iPlayer streams on the Shield TV.  Had my default (aka desktop) resolution at 3840x2160p and manually whitelist selected 3840x2160, 1920x1080 and 1280x720 frame rates I also wanted to use.  When I tried playing 2160p50 streams it didn't select 2160p50 - I assumed because it wasn't in the whitelist - and went to 1080p50 instead.   
 So - now you have a hidden bug agenda here :-) So even WITH the correct resolution in whitelist it does not switch to it?  
No - with the correct resolution in the whitelist in your test builds it DOES switch to it.

The behaviour I mentioned above was in the nightlies.
Reply
#51
(2018-06-30, 21:04)noggin Wrote:
(2018-06-30, 20:52)fritsch Wrote:
(2018-06-30, 20:50)noggin Wrote:  I used to do that - but was trying the new BBC UHD iPlayer streams on the Shield TV.  Had my default (aka desktop) resolution at 3840x2160p and manually whitelist selected 3840x2160, 1920x1080 and 1280x720 frame rates I also wanted to use.  When I tried playing 2160p50 streams it didn't select 2160p50 - I assumed because it wasn't in the whitelist - and went to 1080p50 instead.   
 So - now you have a hidden bug agenda here :-) So even WITH the correct resolution in whitelist it does not switch to it?   
No - with the correct resolution in the whitelist in your test builds it DOES switch to it.

The behaviour I mentioned above was in the nightlies. 
 Perfect. Curious on the version that is currently building. Would be nice if you could test that one please: fritsch-androidrf-212632f

Thanks in advance.
First decide what functions / features you expect from a system. Then decide for the hardware. Don't waste your money on crap.
Reply
#52
(2018-06-30, 21:06)fritsch Wrote:
(2018-06-30, 21:04)noggin Wrote:
(2018-06-30, 20:52)fritsch Wrote:  So - now you have a hidden bug agenda here :-) So even WITH the correct resolution in whitelist it does not switch to it?   
No - with the correct resolution in the whitelist in your test builds it DOES switch to it.

The behaviour I mentioned above was in the nightlies.  
 Perfect. Curious on the version that is currently building. Would be nice if you could test that one please: fritsch-androidrf-212632f

Thanks in advance. 
I am - of course - now convincing myself I'm wrong...

(But who thought it was a good idea to remove your current resolution and frame rate from the whitelist?)
Reply
#53
(2018-06-30, 21:17)noggin Wrote:
(2018-06-30, 21:06)fritsch Wrote:
(2018-06-30, 21:04)noggin Wrote: No - with the correct resolution in the whitelist in your test builds it DOES switch to it.

The behaviour I mentioned above was in the nightlies.  
 Perfect. Curious on the version that is currently building. Would be nice if you could test that one please: fritsch-androidrf-212632f

Thanks in advance.  
I am - of course - now convincing myself I'm wrong...

(But who thought it was a good idea to remove your current resolution and frame rate from the whitelist?) 
 There are two design flaws here:

With the assumption that:
a) RES_DESKTOP is always kodi's "desktop resolution" AND
b) That this RES_DESKTOP resolution is always checked first before going to the whitelist

it would have been perfectly fine. But - both assumptions are wrong :-)
First decide what functions / features you expect from a system. Then decide for the hardware. Don't waste your money on crap.
Reply
#54
@fritsch Should I try this new build  kodi-20180630-212632f8-androidrf-arm64-v8a.apk ?
Reply
#55
Yes exactly, please.
First decide what functions / features you expect from a system. Then decide for the hardware. Don't waste your money on crap.
Reply
#56
Anyway - I did - http://paste.kodi.tv/ejusedejes

That presented all the modes I'd expect in the whitelist (including the main/default/desktop resolution), with no repetition, and works correctly for me with 2160p50.
Reply
#57
Cool as expected. Then now someone needs to tell what Android platform is doing wrong with RES_DESKTOP management ... I have no idea :-)
First decide what functions / features you expect from a system. Then decide for the hardware. Don't waste your money on crap.
Reply
#58
OK, so I've been standing on the sidelines watching the experts figure this out.  It looks like there is a solution (at least a temporary one).  
How does a mere mortal like me get a copy of a working file?  Does this get incorporated into a nightly build?  
Thanks
Reply
#59
http://mirrors.kodi.tv/test-builds/andro...64-v8a.apk via: http://mirrors.kodi.tv/test-builds/android/arm64-v8a/ the 32 bit version is in the arm folder instead
First decide what functions / features you expect from a system. Then decide for the hardware. Don't waste your money on crap.
Reply
#60
Thanks, I'll give it a try!
Reply
  • 1
  • 2
  • 3
  • 4(current)
  • 5
  • 6
  • 8

Logout Mark Read Team Forum Stats Members Help
Whitelist modes missing?0